Merge lp:~mzanetti/unity8/fix-spread-bg into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 1435
Merged at revision: 1445
Proposed branch: lp:~mzanetti/unity8/fix-spread-bg
Merge into: lp:unity8
Diff against target: 25 lines (+2/-2)
2 files modified
qml/Stages/PhoneStage.qml (+1/-1)
qml/Stages/TabletStage.qml (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/unity8/fix-spread-bg
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
Review via email: mp+241674@code.launchpad.net

Commit message

change spread background color to 111111

This helps to make black app surfaces (e.g. camera-app) more visible

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

nope

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yep

 * Did you make sure that your branch does not contain spurious tags?

I did

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

this is fixing a bug reported by desing, vesa already tried it on his device before reporting the bug, so should be fine with them.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, it will break when someone has #111111 has background color, but i guess it's less common than black

* Did CI run pass?
autopilot still borked

* Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Stages/PhoneStage.qml'
2--- qml/Stages/PhoneStage.qml 2014-11-04 12:52:02 +0000
3+++ qml/Stages/PhoneStage.qml 2014-11-13 12:29:13 +0000
4@@ -33,7 +33,7 @@
5 property real inverseProgress: 0 // This is the progress for left edge drags, in pixels.
6 property int orientation: Qt.PortraitOrientation
7
8- color: "black"
9+ color: "#111111"
10
11 function select(appId) {
12 spreadView.snapTo(priv.indexOf(appId));
13
14=== modified file 'qml/Stages/TabletStage.qml'
15--- qml/Stages/TabletStage.qml 2014-10-30 21:42:32 +0000
16+++ qml/Stages/TabletStage.qml 2014-11-13 12:29:13 +0000
17@@ -25,7 +25,7 @@
18 id: root
19 objectName: "stages"
20 anchors.fill: parent
21- color: "black"
22+ color: "#111111"
23
24 // Controls to be set from outside
25 property bool shown: false

Subscribers

People subscribed via source and target branches