Merge lp:~mzanetti/unity8/fix-resize-bug into lp:unity8

[Michael Zanetti]

don't make windowedX/Y/W/H a binding... it will have some weird effects

windowedX/Y/W/H values are usually written by imperative code, this
binding only works as long as the user doesn't move the window
manually anyways. In addition, it introduces some bug with resizing
before any move operation happened.

 * Are there any related MPs required for this MP to build/function as expected? Please list.

see prereq

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

no

 * If you changed the UI, has there been a design review?

no

[Lukáš Tinkl (lukas-kde)]

We'll need something better; this way, on an external screen, the windows are tiny on startup, then they very often grow to a size that overflows the screen. Edges are not visible, thus you can't resize them back to normal.

review: Needs Fixing

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2605
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2360/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3113
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1757
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1757
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1757
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3141
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2997
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2997/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2997
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2997/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2997
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2997/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2997
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2997/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2997
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2997/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2997
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2997/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2997
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2997/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2997
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2997/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2997
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2997/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2360/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

@Daniel, how would mirAL impact this? I suppose you'd remove those bindings anyways?

[Daniel d'Andrada (dandrader)]

Looks like you forgot to specify the prerequisite of this branch

[Michael Zanetti (mzanetti)]

which is why there is a superseding MP :)

[Daniel d'Andrada (dandrader)]

This won't affect mirAL changes.

But these were made as bindings to fix a bug (they were originally simple assignments as you're doing now). bzr history should tell what exactly is the bug these bindings are fixing.

Unmerged revisions

2605. By Michael Zanetti on 2016-10-12

don't make windowedX/Y/W/H a binding... it will have some weird effects

windowedX/Y/W/H values are usually written by imperative code, this
binding only works as long as the user doesn't move the window
manually anyways. In addition, it introduces some bug with resizing
before any move operation happened.

=== modified file 'qml/Stage/WindowResizeArea.qml'
--- qml/Stage/WindowResizeArea.qml	2016-10-12 10:06:28 +0000
+++ qml/Stage/WindowResizeArea.qml	2016-10-12 10:06:30 +0000
@@ -78,12 +78,12 @@
                                                             Qt.rect(target.windowedX, target.windowedY, defaultWidth, defaultHeight));
 
 
-        target.windowedWidth = Qt.binding(function() { return Math.min(Math.max(windowGeometry.width, d.minimumWidth), screenWidth - root.leftMargin); });
-        target.windowedHeight = Qt.binding(function() { return Math.min(Math.max(windowGeometry.height, d.minimumHeight),
-                                                                         root.screenHeight - (target.fullscreen ? 0 : PanelState.panelHeight)); });
-        target.windowedX = Qt.binding(function() { return Math.max(Math.min(windowGeometry.x, root.screenWidth - root.leftMargin - target.windowedWidth),
-                                                           (target.fullscreen ? 0 : root.leftMargin)); });
-        target.windowedY = Qt.binding(function() { return Math.max(Math.min(windowGeometry.y, root.screenHeight - target.windowedHeight), PanelState.panelHeight); });
+        target.windowedWidth = Math.min(Math.max(windowGeometry.width, d.minimumWidth), screenWidth - root.leftMargin);
+        target.windowedHeight = Math.min(Math.max(windowGeometry.height, d.minimumHeight),
+                                                    root.screenHeight - (target.fullscreen ? 0 : PanelState.panelHeight));
+        target.windowedX = Math.max(Math.min(windowGeometry.x, root.screenWidth - root.leftMargin - target.windowedWidth),
+                                                   (target.fullscreen ? 0 : root.leftMargin));
+        target.windowedY = Math.max(Math.min(windowGeometry.y, root.screenHeight - target.windowedHeight), PanelState.panelHeight);
 
         var windowState = windowStateStorage.getState(root.windowId, WindowStateStorage.WindowStateNormal)
         target.restore(false /* animated */, windowState);