Merge lp:~mzanetti/unity8/fix-lockscreen-error-label into lp:unity8
Proposed by
Michael Zanetti
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michael Terry | ||||
Approved revision: | 1336 | ||||
Merged at revision: | 1351 | ||||
Proposed branch: | lp:~mzanetti/unity8/fix-lockscreen-error-label | ||||
Merge into: | lp:unity8 | ||||
Diff against target: |
11 lines (+1/-0) 1 file modified
qml/Components/PinLockscreen.qml (+1/-0) |
||||
To merge this branch: | bzr merge lp:~mzanetti/unity8/fix-lockscreen-error-label | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Michael Terry | Approve | ||
Review via email: mp+237606@code.launchpad.net |
Commit message
scale down errorText label if necessary
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* Did you make sure that your branch does not contain spurious tags?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Scale is an Item-level property? That's nuts, in a good way. That would have been useful for a previous branch of mine. Ah well.
LGTM
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
TBD, but it won't pass, for unrelated reasons
* Did you make sure that the branch does not contain spurious tags?
Yes