Merge lp:~mzanetti/unity8/fix-lockscreen-error-label into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Michael Terry
Approved revision: 1336
Merged at revision: 1351
Proposed branch: lp:~mzanetti/unity8/fix-lockscreen-error-label
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
qml/Components/PinLockscreen.qml (+1/-0)
To merge this branch: bzr merge lp:~mzanetti/unity8/fix-lockscreen-error-label
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Terry Approve
Review via email: mp+237606@code.launchpad.net

Commit message

scale down errorText label if necessary

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

 * If you changed the UI, has there been a design review?

N/A

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Scale is an Item-level property? That's nuts, in a good way. That would have been useful for a previous branch of mine. Ah well.

LGTM

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 Yes

 * Did CI run pass? If not, please explain why.
 TBD, but it won't pass, for unrelated reasons

 * Did you make sure that the branch does not contain spurious tags?
 Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Components/PinLockscreen.qml'
2--- qml/Components/PinLockscreen.qml 2014-09-23 22:38:16 +0000
3+++ qml/Components/PinLockscreen.qml 2014-10-08 14:34:21 +0000
4@@ -114,6 +114,7 @@
5 horizontalAlignment: Text.AlignHCenter
6 text: root.errorText
7 visible: pinentryField.incorrectOverride
8+ scale: Math.min(1, parent.width / width)
9 }
10
11 AbstractButton {

Subscribers

People subscribed via source and target branches