Merge lp:~mzanetti/unity8/fix-drawer-hiding-on-quick-meta-a into lp:unity8
Proposed by
Michael Zanetti
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Albert Astals Cid | ||||
Approved revision: | 2837 | ||||
Merged at revision: | 2853 | ||||
Proposed branch: | lp:~mzanetti/unity8/fix-drawer-hiding-on-quick-meta-a | ||||
Merge into: | lp:unity8 | ||||
Diff against target: |
61 lines (+33/-0) 2 files modified
plugins/Utils/WindowInputMonitor.cpp (+3/-0) tests/plugins/Utils/WindowInputMonitorTest.cpp (+30/-0) |
||||
To merge this branch: | bzr merge lp:~mzanetti/unity8/fix-drawer-hiding-on-quick-meta-a | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot | continuous-integration | Approve | |
Albert Astals Cid (community) | Approve | ||
Review via email:
|
Commit message
Cancel the home key activation if something else is pressed along with Meta
This fixes emitting a "home key pressed" signal if the actual press was a combination
of Meta + something else which in turn caused problems like the drawer hiding again
on a very quick Meta+A press.
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
no
* If you changed the UI, has there been a design review?
no
To post a comment you must log in.
FAILED: Continuous integration, rev:2834 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3168/ /unity8- jenkins. ubuntu. com/job/ build/4157/ console /unity8- jenkins. ubuntu. com/job/ build-0- fetch/4185 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 4023/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= zesty/4023/ console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 4023/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= zesty/4023/ console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 4023/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= zesty/4023/ console
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3168/ rebuild
https:/