Merge lp:~mzanetti/unity8/fix-cmake-sql-warnings into lp:unity8

Proposed by Michael Zanetti on 2015-02-12
Status: Merged
Approved by: Michał Sawicz on 2015-02-12
Approved revision: 1598
Merged at revision: 1616
Proposed branch: lp:~mzanetti/unity8/fix-cmake-sql-warnings
Merge into: lp:unity8
Prerequisite: lp:~mzanetti/unity8/saveRestoreWindowSizePosition
Diff against target: 11 lines (+1/-0)
1 file modified
CMakeLists.txt (+1/-0)
To merge this branch: bzr merge lp:~mzanetti/unity8/fix-cmake-sql-warnings
Reviewer Review Type Date Requested Status
Michał Sawicz 2015-02-12 Approve on 2015-02-12
PS Jenkins bot continuous-integration Approve on 2015-02-12
Review via email: mp+249478@code.launchpad.net

Commit Message

Cleanup cmake warning about missing Qt5Sql module

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
prereq

 * Did you perform an exploratory manual test run of your code change and any related functionality?
yes

 * Did you make sure that your branch does not contain spurious tags?
yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a

 * If you changed the UI, has there been a design review?
n/a

To post a comment you must log in.
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
+1, no more warnings.

 * Did CI run pass? If not, please explain why.
Y

 * Did you make sure that the branch does not contain spurious tags?
Y

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-12-02 18:47:49 +0000
3+++ CMakeLists.txt 2015-02-12 12:12:38 +0000
4@@ -54,6 +54,7 @@
5 find_package(Qt5Gui 5.2 REQUIRED)
6 find_package(Qt5DBus 5.2 REQUIRED)
7 find_package(Qt5Concurrent 5.2 REQUIRED)
8+find_package(Qt5Sql 5.2 REQUIRED)
9
10 # Standard install paths
11 include(GNUInstallDirs)

Subscribers

People subscribed via source and target branches