Merge lp:~mzanetti/unity8/fix-blurry-bfb into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Lukáš Tinkl
Approved revision: 2838
Merged at revision: 2855
Proposed branch: lp:~mzanetti/unity8/fix-blurry-bfb
Merge into: lp:unity8
Diff against target: 266 lines (+246/-1)
2 files modified
qml/Launcher/LauncherPanel.qml (+3/-1)
qml/Launcher/graphics/home.svg (+243/-0)
To merge this branch: bzr merge lp:~mzanetti/unity8/fix-blurry-bfb
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Lukáš Tinkl (community) Approve
Review via email: mp+318471@code.launchpad.net

Commit message

use a svg instead of a png for the Launcher's BFB

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
no
 * Did you perform an exploratory manual test run of your code change and any related functionality?
yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

To post a comment you must log in.
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

Yup, sharp as a knife :)

* Did you perform an exploratory manual test run of the code change and any related functionality?

Yes

* Did CI run pass? If not, please explain why.

Waiting

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2838
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3227/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4233
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2506
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2506
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4261
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4096
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4096/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4096
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4096/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4096
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4096/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4096
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4096/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4096
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4096/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4096
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4096/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3227/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Launcher/LauncherPanel.qml'
2--- qml/Launcher/LauncherPanel.qml 2017-01-31 14:30:21 +0000
3+++ qml/Launcher/LauncherPanel.qml 2017-02-28 13:02:40 +0000
4@@ -92,8 +92,10 @@
5 objectName: "dashItem"
6 width: parent.width * .6
7 height: width
8+ sourceSize.width: width
9+ sourceSize.height: height
10 anchors.centerIn: parent
11- source: "graphics/home.png"
12+ source: "graphics/home.svg"
13 rotation: root.rotation
14 }
15 AbstractButton {
16
17=== added file 'qml/Launcher/graphics/home.svg'
18--- qml/Launcher/graphics/home.svg 1970-01-01 00:00:00 +0000
19+++ qml/Launcher/graphics/home.svg 2017-02-28 13:02:40 +0000
20@@ -0,0 +1,243 @@
21+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
22+<!-- Created with Inkscape (http://www.inkscape.org/) -->
23+
24+<svg
25+ xmlns:dc="http://purl.org/dc/elements/1.1/"
26+ xmlns:cc="http://creativecommons.org/ns#"
27+ xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
28+ xmlns:svg="http://www.w3.org/2000/svg"
29+ xmlns="http://www.w3.org/2000/svg"
30+ xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
31+ xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
32+ viewBox="0 0 90 89.999999"
33+ style="enable-background:new"
34+ inkscape:export-ydpi="180"
35+ inkscape:export-xdpi="180"
36+ inkscape:export-filename="app_shape02.png"
37+ sodipodi:docname="home@18.svg"
38+ inkscape:version="0.92+devel unknown"
39+ version="1.1"
40+ id="svg3336"
41+ height="90"
42+ width="90">
43+ <sodipodi:namedview
44+ inkscape:snap-global="false"
45+ fit-margin-bottom="0"
46+ fit-margin-right="0"
47+ fit-margin-left="0"
48+ fit-margin-top="0"
49+ inkscape:snap-grids="true"
50+ inkscape:guide-bbox="true"
51+ showguides="false"
52+ inkscape:snap-center="true"
53+ inkscape:snap-object-midpoints="true"
54+ inkscape:snap-midpoints="true"
55+ inkscape:snap-smooth-nodes="true"
56+ inkscape:snap-intersection-paths="true"
57+ inkscape:object-nodes="true"
58+ inkscape:object-paths="true"
59+ inkscape:snap-bbox-midpoints="true"
60+ inkscape:snap-bbox-edge-midpoints="true"
61+ inkscape:bbox-nodes="true"
62+ inkscape:bbox-paths="true"
63+ inkscape:snap-bbox="true"
64+ showborder="true"
65+ inkscape:showpageshadow="false"
66+ inkscape:snap-page="true"
67+ inkscape:window-maximized="1"
68+ inkscape:window-y="24"
69+ inkscape:window-x="0"
70+ inkscape:window-height="1029"
71+ inkscape:window-width="1920"
72+ showgrid="false"
73+ inkscape:current-layer="layer1"
74+ inkscape:document-units="px"
75+ inkscape:cy="-8.7116629"
76+ inkscape:cx="2.9876656"
77+ inkscape:zoom="1.5625"
78+ inkscape:pageshadow="2"
79+ inkscape:pageopacity="0"
80+ borderopacity="1.0"
81+ bordercolor="#666666"
82+ pagecolor="#4f4f4f"
83+ id="base"
84+ inkscape:document-rotation="0">
85+ <inkscape:grid
86+ type="xygrid"
87+ id="grid811"
88+ originx="-211"
89+ originy="-195.00023"
90+ visible="true"
91+ enabled="true" />
92+ <sodipodi:guide
93+ orientation="1,0"
94+ position="-107,-35.000232"
95+ id="guide819"
96+ inkscape:locked="false" />
97+ <sodipodi:guide
98+ orientation="1,0"
99+ position="-91,-51.000232"
100+ id="guide821"
101+ inkscape:locked="false" />
102+ <sodipodi:guide
103+ orientation="1,0"
104+ position="181,-67.000232"
105+ id="guide823"
106+ inkscape:locked="false" />
107+ <sodipodi:guide
108+ orientation="1,0"
109+ position="197,-67.000232"
110+ id="guide825"
111+ inkscape:locked="false" />
112+ <sodipodi:guide
113+ orientation="0,1"
114+ position="117,196.99977"
115+ id="guide827"
116+ inkscape:locked="false" />
117+ <sodipodi:guide
118+ orientation="0,1"
119+ position="125,180.99977"
120+ id="guide829"
121+ inkscape:locked="false" />
122+ <sodipodi:guide
123+ orientation="0,1"
124+ position="-35,-91.000232"
125+ id="guide831"
126+ inkscape:locked="false" />
127+ <sodipodi:guide
128+ orientation="0,1"
129+ position="5.0000002,-107.00023"
130+ id="guide833"
131+ inkscape:locked="false" />
132+ <inkscape:grid
133+ type="axonomgrid"
134+ id="grid835"
135+ units="px"
136+ empspacing="60"
137+ gridanglex="42.9"
138+ gridanglez="42.9"
139+ spacingy="3.522px"
140+ enabled="false"
141+ originx="-211"
142+ originy="-194.00023" />
143+ <sodipodi:guide
144+ orientation="0,1"
145+ position="133,164.99977"
146+ id="guide4126"
147+ inkscape:locked="false" />
148+ <sodipodi:guide
149+ orientation="0,1"
150+ position="-51,-75.000232"
151+ id="guide4128"
152+ inkscape:locked="false" />
153+ <sodipodi:guide
154+ orientation="1,0"
155+ position="-75,-115.00023"
156+ id="guide4130"
157+ inkscape:locked="false" />
158+ <sodipodi:guide
159+ orientation="1,0"
160+ position="165,-75.000232"
161+ id="guide4134"
162+ inkscape:locked="false" />
163+ <sodipodi:guide
164+ orientation="-0.70710678,0.70710678"
165+ position="333,332.99977"
166+ id="guide4136"
167+ inkscape:locked="false" />
168+ <sodipodi:guide
169+ orientation="1,0"
170+ position="45,-243.00023"
171+ id="guide4138"
172+ inkscape:locked="false" />
173+ <sodipodi:guide
174+ orientation="0,1"
175+ position="333,44.999767"
176+ id="guide4140"
177+ inkscape:locked="false" />
178+ <sodipodi:guide
179+ orientation="0.70710678,0.70710678"
180+ position="333,-243.00023"
181+ id="guide4142"
182+ inkscape:locked="false" />
183+ <sodipodi:guide
184+ orientation="0,1"
185+ position="37,-195.00023"
186+ id="guide4152"
187+ inkscape:locked="false" />
188+ <sodipodi:guide
189+ orientation="0,1"
190+ position="125,284.99977"
191+ id="guide4154"
192+ inkscape:locked="false" />
193+ <sodipodi:guide
194+ position="133,-115.00023"
195+ orientation="1,0"
196+ id="guide4361"
197+ inkscape:locked="false" />
198+ <sodipodi:guide
199+ position="365,-43.000232"
200+ orientation="0,1"
201+ id="guide4363"
202+ inkscape:locked="false" />
203+ <sodipodi:guide
204+ position="-43,-19.000232"
205+ orientation="1,0"
206+ id="guide4229"
207+ inkscape:locked="false" />
208+ <sodipodi:guide
209+ position="101,132.99977"
210+ orientation="0,1"
211+ id="guide4233"
212+ inkscape:locked="false" />
213+ <sodipodi:guide
214+ position="-30.52,-307.00023"
215+ orientation="0,1"
216+ id="guide4235"
217+ inkscape:locked="false" />
218+ </sodipodi:namedview>
219+ <defs
220+ id="defs3338">
221+ <clipPath
222+ clipPathUnits="userSpaceOnUse"
223+ id="clipPath4755">
224+ <path
225+ style="color:#000000;opacity:0.24899998;fill:#5e2c73;stroke-width:5"
226+ d="M 360,50 594,284 V 215.89844 C 594,70.73665 573.2426,50 427.94531,50 Z"
227+ id="path4757"
228+ inkscape:connector-curvature="0" />
229+ </clipPath>
230+ <clipPath
231+ clipPathUnits="userSpaceOnUse"
232+ id="clipPath4767">
233+ <path
234+ style="color:#000000;fill:#f6f6f6;stroke-width:5"
235+ d="M 543.8125,454.1875 312.18945,685.81055 367.94531,681 C 512.70468,668.50896 526.55393,654.72881 539,510.10156 Z"
236+ id="path4769"
237+ inkscape:connector-curvature="0" />
238+ </clipPath>
239+ </defs>
240+ <metadata
241+ id="metadata3341">
242+ <rdf:RDF>
243+ <cc:Work
244+ rdf:about="">
245+ <dc:format>image/svg+xml</dc:format>
246+ <dc:type
247+ rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
248+ <dc:title></dc:title>
249+ </cc:Work>
250+ </rdf:RDF>
251+ </metadata>
252+ <g
253+ inkscape:groupmode="layer"
254+ id="layer1"
255+ inkscape:label="Pictogram"
256+ transform="translate(-243,-242.99977)">
257+ <path
258+ style="color:#000000;fill:#ffffff;stroke-width:8;stroke-linecap:square"
259+ d="m 288,243.00023 a 44.999951,44.999951 0 0 0 -45,45 44.999951,44.999951 0 0 0 45,44.99954 44.999951,44.999951 0 0 0 45,-44.99954 44.999951,44.999951 0 0 0 -45,-45 z m 14.57434,13.77039 c 1.02065,-0.0231 2.06021,0.22446 3.0092,0.77195 2.76095,1.59476 3.70514,5.12339 2.11064,7.88408 -1.59271,2.76068 -5.12109,3.70488 -7.88178,2.11064 -2.75891,-1.59271 -3.70494,-5.12125 -2.11248,-7.88041 1.04672,-1.8117 2.9259,-2.84213 4.87442,-2.88626 z m -14.5748,6.15598 c 2.32096,0 4.56584,0.32221 6.69895,0.91089 0.37619,2.31944 1.75264,4.4561 3.94752,5.7227 2.19107,1.26304 4.72599,1.38994 6.92062,0.56079 4.26774,4.19709 7.04521,9.90478 7.44987,16.26267 l -8.22457,0.12112 C 304.03344,277.89278 296.80747,271.1402 288,271.1402 c -2.53726,0 -4.9441,0.5641 -7.10161,1.56813 l -4.01059,-7.18662 c 3.34938,-1.65779 7.12182,-2.59511 11.11174,-2.59511 z m -13.90979,4.21169 4.21992,7.06779 c -4.3351,3.05147 -7.16833,8.09073 -7.16833,13.79461 0,5.70414 2.83323,10.74309 7.16833,13.79278 l -4.21992,7.06916 c -5.0519,-3.37556 -8.80916,-8.53411 -10.36858,-14.57708 1.82199,-1.48672 2.98818,-3.74984 2.98818,-6.28532 0,-2.53701 -1.16619,-4.80043 -2.98818,-6.28715 1.56145,-6.04118 5.31871,-11.19923 10.36858,-14.57479 z m -15.48569,15.08943 c 3.18747,0 5.7716,2.58397 5.7716,5.77297 0,3.18746 -2.58413,5.77114 -5.7716,5.77114 -3.18924,0 -5.77296,-2.58368 -5.77296,-5.77114 0,-3.189 2.58372,-5.77297 5.77296,-5.77297 z m 46.18604,7.2666 8.2264,0.12112 c -0.40465,6.3579 -3.18213,12.06558 -7.44987,16.26267 -2.19462,-0.82915 -4.72803,-0.70428 -6.92062,0.5608 -2.19438,1.26888 -3.57087,3.40326 -3.94706,5.72269 -2.13286,0.59047 -4.378,0.91318 -6.69895,0.91318 -3.99018,0 -7.76236,-0.93758 -11.11175,-2.5974 l 4.0106,-7.18662 c 2.15726,1.00378 4.56389,1.56859 7.10115,1.56859 8.80772,0 16.03339,-6.75074 16.7901,-15.36503 z m -1.96713,18.19415 c 1.94837,0.044 3.82782,1.0739 4.87304,2.88443 1.59449,2.76095 0.64796,6.28907 -2.11247,7.88179 -2.76069,1.5945 -6.28862,0.64822 -7.88133,-2.11247 -1.59475,-2.75917 -0.64821,-6.2873 2.11247,-7.88179 0.94829,-0.5475 1.98772,-0.795 3.00829,-0.77196 z"
260+ id="circle4206"
261+ inkscape:connector-curvature="0" />
262+ </g>
263+</svg>
264
265=== removed file 'qml/Launcher/graphics/home@18.png'
266Binary files qml/Launcher/graphics/home@18.png 2016-06-03 23:00:28 +0000 and qml/Launcher/graphics/home@18.png 1970-01-01 00:00:00 +0000 differ

Subscribers

People subscribed via source and target branches