Merge lp:~mzanetti/unity/phablet-unload-far-away-images into lp:unity/phablet

[Michael Zanetti]

Unload images on Dashes further away than 1 index from currentIndex.

Originally proposed by Kaleo, merged and completed.

On large screens (tested with 2540x1600 - similar to Nexus 10) this saves up to 70MB of memory after traversing all lens once. On smaller screens its obviously less (On the Galaxy Nexus ~ 15MB).

[Michael Zanetti (mzanetti)]

On the Nexus 10, when swiping to the Video lens, and then very quickly all the way to the Music lens, you can see the Images how they need to get loaded. Right now the UbuntuShapes are black while reloading the images, caused by this bug: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1132771. Once this bug is fixed, one can still see the images missing and appearing only a second after switching to a Dash. Is that still ok?

Another bug, again in the UbuntuShape, that gets visible with this change is this https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1171437. Once fixed, this shouldn't be an issue any more.

[Michael Zanetti (mzanetti)]

> On the Nexus 10, when swiping to the Video lens, and then very quickly all the
> way to the Music lens, you can see the Images how they need to get loaded.
> Right now the UbuntuShapes are black while reloading the images, caused by
> this bug: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1132771. Once this
> bug is fixed, one can still see the images missing and appearing only a second
> after switching to a Dash. Is that still ok?

Investigating a bit more, this only seems to be an issue on the Music and People lenses. The reason for that is that they get loaded from bottom to top. As currently LVWPH always shows ALL items, it takes a second until the topmost images are loaded. The rework of LVWPH will therefore improve this greatly as visible items will be loaded immediately

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:616
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/698/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/515
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/700
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/700/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/698
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/574
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/574/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/578
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1230

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/698/rebuild

review: Approve (continuous-integration)

[Michał Sawicz (saviq)]

When switching lenses using the dash bar, the current-before-you-clicked lens disappears straight away.

We should delay the unloading a half a second or so to also reduce unnecessary reloads when quickly switching between lenses.

I would also later like to experiment with layers to keep a cache of the unloaded lenses' views.

And generally we need design input on what to do with long-loading images / lenses.

review: Needs Fixing

[lp:~mzanetti/unity/phablet-unload-far-away-images]

617. By Michael Zanetti on 2013-04-23

add a grace period before hiding lens

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:617
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/727/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/552
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/729
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/729/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/727
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/603
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/603/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/607
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1269

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/727/rebuild

review: Approve (continuous-integration)

[Andrea Cimitan (cimi)]

I'm wondering whether we could make UbuntuShape support automatic unloading, especially when items are not visible (through a bool property).

[Michael Zanetti (mzanetti)]

> I'm wondering whether we could make UbuntuShape support automatic unloading,
> especially when items are not visible (through a bool property).

you mean like this?

UbuntuShape {
  unloadWhenIvisible: true
}

hmm... not sure...
* I still hope we can upstream our UbuntuShape to the SDK at some point.
* our ubuntushape can display Items, not only images. what would that do? unload all the items? walk through the children item tree and unload all the images in there? Seems to be too may different cases for such an API. Mostly people wouldn't use this property but still specifically select the things to unload themselves.

[Michael Zanetti (mzanetti)]

> When switching lenses using the dash bar, the current-before-you-clicked lens
> disappears straight away.
>
> We should delay the unloading a half a second or so to also reduce unnecessary
> reloads when quickly switching between lenses.

Fixed, btw.

> I would also later like to experiment with layers to keep a cache of the
> unloaded lenses' views.

Interesting idea... without having tested it I guess that will keep lots of megabytes in the graphics chip memory... Seems equally bad if not even worse on a first thought. I didn't think it fully through tho.

[Michał Sawicz (saviq)]

35 + property bool gracePeriodRunning: false

Do we actually need a separate property? Shouldn't just "running" on the Timer suffice?

49 + unloadTimer.start();

Hmm shouldn't we restart instead?

review: Needs Information

[Michał Sawicz (saviq)]

I got to 254M RSS with this patch, 300M without. I don't understand the raise in mem usage after having played with the dash as we're loading the whole thing from the get-go...

But anyway a nice save - and we should be able to reduce its impact by only loading images that are actually going to be visible.

[Michał Sawicz (saviq)]

Hey, any update on this?

[Michael Zanetti (mzanetti)]

> 35 + property bool gracePeriodRunning: false
>
> Do we actually need a separate property? Shouldn't just "running" on the Timer
> suffice?

I need a property that tells me if the current dash has been the active one before switching away. The comparison could indeed happen on the timer but as some sort of property is needed anyways, I decided to also use it for the rest for better readability.

>
> 49 + unloadTimer.start();
>
> Hmm shouldn't we restart instead?

Ack. fixed

[lp:~mzanetti/unity/phablet-unload-far-away-images]

618. By Michael Zanetti on 2013-05-15

restart instead of start

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:618
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/927/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/885
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/803
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/803/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/807
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1457

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/927/rebuild

review: Approve (continuous-integration)

[Michał Sawicz (saviq)]

Hmm this makes the shell perform badly after some playing... If I scroll between lenses a few times and scroll the lenses themselves, at some point the shell starts to be really jerky and doesn't stop being so.

Happened both on a Galaxy Nexus and a Nexus 10.

Can you see if you can reproduce?

review: Needs Information

[Michael Zanetti (mzanetti)]

> Hmm this makes the shell perform badly after some playing... If I scroll
> between lenses a few times and scroll the lenses themselves, at some point the
> shell starts to be really jerky and doesn't stop being so.
>
> Happened both on a Galaxy Nexus and a Nexus 10.
>
> Can you see if you can reproduce?

Reproduced, created a test case and reported a bug: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1180794

Unmerged revisions

618. By Michael Zanetti on 2013-05-15

restart instead of start

617. By Michael Zanetti on 2013-04-23

add a grace period before hiding lens

616. By Michael Zanetti on 2013-04-22

Do not load images that are invisible and set lenses that are far to be invisible.

Initially proposed by Kaleo. Merged and completed.

=== modified file 'Dash/Apps/ApplicationsFilterGrid.qml'
--- Dash/Apps/ApplicationsFilterGrid.qml	2013-04-15 14:31:47 +0000
+++ Dash/Apps/ApplicationsFilterGrid.qml	2013-05-15 14:52:28 +0000
@@ -50,7 +50,7 @@
         text: model.column_4 ? model.column_4 : application.name // FIXME: this is temporary
         imageWidth: units.gu(8)
         imageHeight: units.gu(7.5)
-        source: icon.indexOf("/") == -1 ? "image://gicon/" + icon : icon
+        source: visible ? (icon.indexOf("/") == -1 ? "image://gicon/" + icon : icon) : ""
         onClicked: filterGrid.clicked(index, application.desktopFile);
     }
 }

=== modified file 'Dash/Apps/RunningApplicationTile.qml'
--- Dash/Apps/RunningApplicationTile.qml	2013-04-29 19:21:59 +0000
+++ Dash/Apps/RunningApplicationTile.qml	2013-05-15 14:52:28 +0000
@@ -76,7 +76,7 @@
 
     ApplicationImage {
         id: applicationImage
-        source: application
+        source: visible ? application : ""
         width: shapedApplicationImage.width
         height: shapedApplicationImage.height
         fillMode: ApplicationImage.PreserveAspectCrop

=== modified file 'Dash/DashContent.qml'
--- Dash/DashContent.qml	2013-04-29 23:47:43 +0000
+++ Dash/DashContent.qml	2013-05-15 14:52:28 +0000
@@ -107,6 +107,8 @@
 
         delegate:
             Loader {
+                visible: (index >= ListView.view.currentIndex - 1 && index <= ListView.view.currentIndex + 1) || gracePeriodRunning
+                property bool gracePeriodRunning: false
                 width: ListView.view.width
                 height: ListView.view.height
                 asynchronous: true
@@ -139,6 +141,24 @@
                         }
                     }
                 }
+                Connections {
+                    target: dashContentList
+                    onCurrentIndexChanged: {
+                        if (dashContentList.currentIndex == index) {
+                            gracePeriodRunning = true;
+                        } else if (gracePeriodRunning) {
+                            unloadTimer.restart();
+                        }
+                    }
+                }
+                Timer {
+                    id: unloadTimer
+                    interval: 1000
+                    repeat: false
+                    onTriggered: {
+                        gracePeriodRunning = false;
+                    }
+                }
             }
     }
 }

=== modified file 'Dash/GenericLensView.qml'
--- Dash/GenericLensView.qml	2013-04-22 15:06:28 +0000
+++ Dash/GenericLensView.qml	2013-05-15 14:52:28 +0000
@@ -74,7 +74,7 @@
                     text: column_4 ? column_4 : "" // FIXME: this shouldn't be necessary
                     imageWidth: units.gu(11)
                     imageHeight: units.gu(16)
-                    source: column_1 ? column_1 : "" // FIXME: ditto
+                    source: column_1 && visible ? column_1 : "" // FIXME: ditto
                 }
             }
         }

=== modified file 'Dash/Music/AlbumTile.qml'
--- Dash/Music/AlbumTile.qml	2013-02-15 15:08:28 +0000
+++ Dash/Music/AlbumTile.qml	2013-05-15 14:52:28 +0000
@@ -33,7 +33,7 @@
         }
         radius: "medium"
         image: Image {
-            source: root.source
+            source: icon.visible ? root.source : ""
             sourceSize { width: icon.width; height: icon.height }
             asynchronous: true
             cache: false

=== modified file 'Dash/Music/CarouselDelegateMusic.qml'
--- Dash/Music/CarouselDelegateMusic.qml	2013-02-18 19:58:47 +0000
+++ Dash/Music/CarouselDelegateMusic.qml	2013-05-15 14:52:28 +0000
@@ -28,7 +28,7 @@
         image: Image {
             asynchronous: true
             sourceSize { width: item.width; height: item.height }
-            source: model ? model.column_1 : ""
+            source: model && item.visible ? model.column_1 : ""
         }
     }
 

=== modified file 'Dash/People/CarouselDelegatePeople.qml'
--- Dash/People/CarouselDelegatePeople.qml	2013-03-15 17:02:25 +0000
+++ Dash/People/CarouselDelegatePeople.qml	2013-05-15 14:52:28 +0000
@@ -31,7 +31,7 @@
         image: Image {
             asynchronous: true
             sourceSize { width: item.width; height: item.height }
-            source: dataModel.avatar ? dataModel.avatar : ""
+            source: dataModel.avatar && item.visible ? dataModel.avatar : ""
             fillMode: Image.PreserveAspectCrop
         }
     }

=== modified file 'Dash/People/Delegate.qml'
--- Dash/People/Delegate.qml	2013-02-15 14:02:54 +0000
+++ Dash/People/Delegate.qml	2013-05-15 14:52:28 +0000
@@ -52,7 +52,7 @@
             height: units.gu(6)
             image: Image {
                 width: units.gu(6)
-                source: peopleView.dataModel.avatar
+                source: avatar.visible ? peopleView.dataModel.avatar : ""
                 sourceSize { width: avatar.width; height: avatar.height }
                 fillMode: Image.PreserveAspectCrop
                 smooth: true

=== modified file 'Dash/Video/CarouselDelegateVideo.qml'
--- Dash/Video/CarouselDelegateVideo.qml	2013-02-18 19:58:47 +0000
+++ Dash/Video/CarouselDelegateVideo.qml	2013-05-15 14:52:28 +0000
@@ -28,7 +28,7 @@
         image: Image {
             asynchronous: true
             sourceSize { width: item.width; height: item.height }
-            source: model ? model.column_1 : ""
+            source: item.visible && model ? model.column_1 : ""
         }
     }
 

=== modified file 'Dash/Video/VideosFilterGrid.qml'
--- Dash/Video/VideosFilterGrid.qml	2013-05-08 13:29:13 +0000
+++ Dash/Video/VideosFilterGrid.qml	2013-05-15 14:52:28 +0000
@@ -40,7 +40,7 @@
         text: model.column_4
         imageWidth: filtergrid.iconWidth
         imageHeight: filtergrid.iconHeight
-        source: model.column_1
+        source: visible ? model.column_1 : ""
         fillMode: Image.PreserveAspectCrop
         onClicked: {
             var fileUri = model.column_0.replace(/^[^:]+:/, "")