Merge lp:~mzanetti/unity/phablet-test-dashpreview into lp:unity/phablet

[Michael Zanetti]

added tests for DashPreview.qml

added tests for DashPreview.qml

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:505
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/121/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/122
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/122/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/121
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/224

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/121/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

Looks good

review: Approve

=== modified file 'Dash/DashPreview.qml'
--- Dash/DashPreview.qml	2013-03-20 11:12:44 +0000
+++ Dash/DashPreview.qml	2013-03-21 17:08:01 +0000
@@ -83,6 +83,7 @@
 
             Label {
                 id: title
+                objectName: "titleLabel"
                 anchors {
                     left: parent.left
                     right: parent.right
@@ -134,6 +135,7 @@
 
             Column {
                 id: leftColumn
+                objectName: "leftColumn"
                 anchors {
                     left: parent.left
                     right: parent.right
@@ -157,6 +159,7 @@
                     }
 
                     Image {
+                        objectName: "playButton"
                         anchors.centerIn: parent
                         visible: root.playable
                         readonly property bool bigButton: parent.width > units.gu(40)
@@ -196,6 +199,7 @@
 
             Column {
                 id: rightColumn
+                objectName: "rightColumn"
                 height: childrenRect.height
                 anchors {
                     left: parent.left

=== modified file 'tests/qmluitests/CMakeLists.txt'
--- tests/qmluitests/CMakeLists.txt	2013-03-20 09:39:25 +0000
+++ tests/qmluitests/CMakeLists.txt	2013-03-21 17:08:01 +0000
@@ -26,3 +26,4 @@
 add_qml_test(Greeter)
 add_qml_test(ResponsiveGridView)
 add_qml_test(Revealer)
+add_qml_test(DashPreview)

=== added file 'tests/qmluitests/tst_DashPreview.qml'
--- tests/qmluitests/tst_DashPreview.qml	1970-01-01 00:00:00 +0000
+++ tests/qmluitests/tst_DashPreview.qml	2013-03-21 17:08:01 +0000
@@ -0,0 +1,173 @@
+/*
+ * Copyright 2013 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.0
+import QtTest 1.0
+import "../../Dash"
+import Ubuntu.Components 0.1
+
+Item {
+    id: root
+    width: units.gu(120)
+    height: units.gu(80)
+
+    property bool helper: false
+
+    UnityTestCase {
+        name: "PreviewTest"
+        when: windowShown
+
+        function test_close() {
+            var title = findChild(preview, "titleLabel")
+            mouseClick(title, 1, 1)
+            compare(closeSpy.count, 1, "Close signal not emitted")
+        }
+
+        function test_play_button_data() {
+            return [
+                {tag: "playable", playable: true},
+                {tag: "not playable", playable: false}
+            ]
+        }
+
+        function test_play_button(data) {
+            var playButton = findChild(preview, "playButton")
+            preview.playable = data.playable
+            compare(playButton.visible, data.playable)
+        }
+
+        function test_play_button_click() {
+            preview.playable = true
+            var playButton = findChild(preview, "playButton")
+            mouseClick(playButton, 1, 1)
+            tryCompare(previewClickedSpy, "count", 1)
+        }
+
+        function test_columns_data() {
+            return [
+                {tag: "1 columns", width: units.gu(5), height: units.gu(10), columns: 1},
+                {tag: "2 columns", width: units.gu(50), height: units.gu(10), columns: 2}
+            ]
+        }
+
+        function test_columns(data) {
+            var leftCol = findChild(preview, "leftColumn")
+            var rightCol = findChild(preview, "rightColumn")
+
+            root.width = data.width
+            root.height = data.height
+
+            // there are 2 columns in DashPreview. On portrait form factors
+            // only the left one is used and the right one should be empty.
+            // to find out if the content is in the correct column, we get a
+            // reference to the column objects and search only the subtree
+            // to see if the content is in the correct column.
+            // 1 colum  -> content should be in leftColumn
+            // 2 colums -> content should be in rightColumn
+
+            switch(data.columns) {
+            case 1:
+                var testContent = findChild(leftCol, "testContent")
+                compare(testContent.objectName, "testContent")
+                break
+            case 2:
+                var testContent = findChild(rightCol, "testContent")
+                compare(testContent.objectName, "testContent")
+                break
+            }
+
+            // reset to initial values to not disturb other tests
+            root.width = units.gu(120)
+            root.height = units.gu(80)
+        }
+
+        // This test just checks if Components assigned to the
+        // "buttons" property are actually put somewhere on the
+        // screen. the mouseClick would fail if they are not used/painted
+        function test_ensure_buttons_visible() {
+            var button = findChild(preview, "buttonMouseArea")
+            mouseClick(button, 1, 1)
+            tryCompare(root, "helper", true)
+            // reset to false in case any other test wants to use it
+            root.helper = false
+        }
+
+    }
+    
+    DashPreview {
+        id: preview
+        anchors.fill: parent
+        title: "Testing rocks, debugging sucks!"
+        forceSquare: true
+
+        buttons: Row {
+            width: parent.width
+            height: units.gu(5)
+            Rectangle {
+                width: parent.width / 3
+                height: parent.height
+                color: "blue"
+                MouseArea {
+                    id: buttonMouseArea
+                    objectName: "buttonMouseArea"
+                    anchors.fill: parent
+                    onClicked: root.helper = true
+                }
+            }
+            Rectangle {
+                width: parent.width / 3
+                height: parent.height
+                color: "green"
+            }
+        }
+
+        caption: Label { text: "Caption label" }
+
+        description: Column {
+            id: testContent
+            objectName: "testContent"
+            width: parent.width
+            height: units.gu(50)
+            Rectangle {
+                width: parent.width
+                height: parent.height / 3
+                color: "green"
+            }
+            Rectangle {
+                width: parent.width
+                height: parent.height / 3
+                color: "red"
+            }
+            Rectangle {
+                width: parent.width
+                height: parent.height / 3
+                color: "blue"
+            }
+        }
+    }
+
+    SignalSpy {
+        id: closeSpy
+        target: preview
+        signalName: "close"
+    }
+
+    SignalSpy {
+        id: previewClickedSpy
+        target: preview
+        signalName: "previewImageClicked"
+    }
+}