Merge lp:~mzanetti/unity/phablet-make-check-hook into lp:unity/phablet

[Michael Zanetti]

added a bzr hook to execute tests on comitting and pushing

to install:
cd .bazaar
make install

added a bzr hook to execute tests on comitting and pushing

to install:
cd .bazaar
make install

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:477
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/68/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/69/console
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/69/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/68/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/68/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:479
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/71/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/72/console
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/72/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/71/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/71/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

Is the extra verbosity there on purpose?

Maybe you want to add a "print "Execute 'make qmluitests'.."" too?

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:480
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/84/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/85/console
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/85/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/84/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/91/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/84/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

tsdgeos_work@xps:~/phablet/lalalal/.bazaar$ make install
make: *** No rule to make target `install'. Stop.

Missing Makefile so that make install does anything?

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:481
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/85/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/86/console
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/86/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/85/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/96/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/85/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

Doesn't seem to working here, any idea?

tsdgeos_work@xps:~/phablet/lalala$ ls ~/.bazaar/plugins/makecheck_unity_phablet.py
/home/tsdgeos_work/.bazaar/plugins/makecheck_unity_phablet.py
tsdgeos_work@xps:~/phablet/lalala$ vi build
tsdgeos_work@xps:~/phablet/lalala$ bzr commit
Committing to: /home/tsdgeos_work/phablet/lalala/
modified build
Committed revision 491.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:482
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/86/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/87/console
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/87/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/86/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/99/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/86/rebuild

review: Approve (continuous-integration)

[Michał Sawicz (saviq)]

Doesn't work with colocated branches :/

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:483
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/110/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/111
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/111/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/110
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/206

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/110/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:484
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/111/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/112
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/112/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/111
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/208

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/111/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

It works for me now, but to be honest even knowing something was going to happen i ended up finding it a bit weird to see all those windows starting to pop out after doing a bzr commit.

review: Approve

[Albert Astals Cid (aacid)]

Actually, needs fixing.

The make uninstall ahs to remove the pyc file too, otherwise the thing keeps executing :D

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:485
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/112/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/113
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/113/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/112
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/210/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/112/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:485
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/114/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/115
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/115/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/114
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/213

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/114/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:487
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/119/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/120
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/120/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/119
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/218

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/119/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:487
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/125/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/126
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/126/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/125
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/1/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/247

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/125/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Ok, so approve with comments, as said in https://code.launchpad.net/~mzanetti/unity/phablet-make-check-hook/+merge/153868/comments/337211 not sure it's something we want, but it does what it says it does.

I'll leave to someone else to decided if we want it in or not

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:487
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/173/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/174
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/174/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/173
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/49
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/49/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/49
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/425

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/173/rebuild

review: Approve (continuous-integration)

[Michał Sawicz (saviq)]

This will conflict with lp:~saviq/unity/phablet.flexible-cmake-macro

review: Needs Fixing

[Michał Sawicz (saviq)]

Please resolve conflicts.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:487
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/239/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/240/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/239/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/115/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/115/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/239/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:488
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/272/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/273
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/273/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/272
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/148
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/148/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/148
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/643

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/272/rebuild

review: Approve (continuous-integration)

=== added directory '.bazaar'
=== added file '.bazaar/Makefile'
--- .bazaar/Makefile	1970-01-01 00:00:00 +0000
+++ .bazaar/Makefile	2013-04-05 08:27:22 +0000
@@ -0,0 +1,6 @@
+install:
+	mkdir -p ~/.bazaar/plugins
+	cp plugins/* ~/.bazaar/plugins
+
+uninstall:
+	rm ~/.bazaar/plugins/makecheck_unity_phablet.py*

=== added directory '.bazaar/plugins'
=== added file '.bazaar/plugins/makecheck_unity_phablet.py'
--- .bazaar/plugins/makecheck_unity_phablet.py	1970-01-01 00:00:00 +0000
+++ .bazaar/plugins/makecheck_unity_phablet.py	2013-04-05 08:27:22 +0000
@@ -0,0 +1,34 @@
+#!/usr/bin/python
+# Copyright 2013 Canonical Ltd.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation; version 3.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import os, subprocess
+from bzrlib import branch, errors
+from bzrlib.urlutils import dirname, local_path_from_url
+
+def execute_makecheck(local_branch, master_branch, old_revision_number, old_revision_id, future_revision_number, future_revision_id, tree_delta, future_tree):
+    if not master_branch.basis_tree().has_filename("Shell.qml"):
+        return
+
+    os.chdir(local_path_from_url(master_branch.base))
+
+    print "Executing 'make check'.."
+    if (subprocess.call("make check", shell=True) != 0):
+        raise errors.BzrError("Unit tests failed, fix them before committing!")
+
+    print "Executing 'make qmluitests'.."
+    if (subprocess.call("make qmluitests", shell=True) != 0):
+        raise errors.BzrError("QML UI tests failed, fix them before committing!")
+
+branch.Branch.hooks.install_named_hook('pre_commit', execute_makecheck, 'make check pre-commit')