Merge lp:~mzanetti/unity/phablet-fix-ap-on-device into lp:unity/phablet

Proposed by Michael Zanetti
Status: Merged
Approved by: Michał Sawicz
Approved revision: no longer in the source branch.
Merged at revision: 709
Proposed branch: lp:~mzanetti/unity/phablet-fix-ap-on-device
Merge into: lp:unity/phablet
Diff against target: 37 lines (+5/-5)
1 file modified
tests/autopilot/qml_phone_shell/tests/__init__.py (+5/-5)
To merge this branch: bzr merge lp:~mzanetti/unity/phablet-fix-ap-on-device
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Approve
Omer Akram (community) Approve
Review via email: mp+166084@code.launchpad.net

Commit message

fix autopilot tests on the phone.

To post a comment you must log in.
Revision history for this message
Omer Akram (om26er) wrote :

Tested those changes already, approved

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

"make autopilot" doesn't work with this.

review: Needs Fixing
Revision history for this message
Michael Zanetti (mzanetti) wrote :

> "make autopilot" doesn't work with this.

Should be fixed now.

Revision history for this message
Michał Sawicz (saviq) wrote :

Let's see what CI has to say.

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote :

This will conflict with lp:~dandrader/unity/phablet_autopilotTouchOnly - so let's merge it here.

Revision history for this message
Michał Sawicz (saviq) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/qml_phone_shell/tests/__init__.py'
2--- tests/autopilot/qml_phone_shell/tests/__init__.py 2013-05-29 11:48:56 +0000
3+++ tests/autopilot/qml_phone_shell/tests/__init__.py 2013-05-29 15:05:30 +0000
4@@ -26,7 +26,7 @@
5 def setUp(self, geometry, grid_size):
6 super(ShellTestCase, self).setUp()
7 # Lets assume we are installed system wide if this file is somewhere in /usr
8- if grid_size != 0:
9+ if grid_size != "0":
10 os.environ['GRID_UNIT_PX'] = grid_size
11 self.grid_size = int(grid_size)
12 else:
13@@ -41,20 +41,20 @@
14 os.environ['QML2_IMPORT_PATH'] = "../../builddir/tests/mocks:../../builddir/plugins"
15 if geometry != "0x0":
16 self.app = self.launch_test_application(
17- "../../builddir/qml-phone-shell", "-geometry", geometry, "-frameless")
18+ "../../builddir/qml-phone-shell", "-geometry", geometry, "-frameless", app_type='qt')
19 else:
20 self.app = self.launch_test_application(
21- "../../builddir/qml-phone-shell", "-fullscreen")
22+ "../../builddir/qml-phone-shell", "-fullscreen", app_type='qt')
23
24 def launch_test_installed(self, geometry):
25 os.environ['LD_LIBRARY_PATH'] = "/usr/share/qml-phone-shell/plugins/mocks/LightDM/full"
26 os.environ['QML2_IMPORT_PATH'] = "/usr/share/qml-phone-shell/plugins/mocks:/usr/share/qml-phone-shell/plugins"
27 if model() == 'Desktop' and geometry != "0x0":
28 self.app = self.launch_test_application(
29- "qml-phone-shell", "-geometry", geometry, "-frameless")
30+ "qml-phone-shell", "-geometry", geometry, "-frameless", app_type='qt')
31 else:
32 self.app = self.launch_test_application(
33- "qml-phone-shell", "-fullscreen")
34+ "qml-phone-shell", "-fullscreen", app_type='qt')
35
36 def skipWrapper(*args, **kwargs):
37 pass

Subscribers

People subscribed via source and target branches