Unity

Merge lp:~mzanetti/unity/phablet-elide-user into lp:unity/phablet

  1. phablet-elide-user
  2. Merge into phablet
Proposed by Michael Zanetti
Status: Merged
Approved by: Albert Astals Cid
Approved revision: no longer in the source branch.
Merged at revision: 484
Proposed branch: lp:~mzanetti/unity/phablet-elide-user
Merge into: lp:unity/phablet
Diff against target: 16 lines (+3/-0)
1 file modified
Greeter/LoginList.qml (+3/-0)
To merge this branch: bzr merge lp:~mzanetti/unity/phablet-elide-user
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+153934@code.launchpad.net

Commit message

elide username when too long

Description of the change

elide username when too long

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:483
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/72/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/73/console
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/73/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/72/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/72/rebuild

review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

It would be cool to unit test this, but last time i tried unitesting font stuff i got small font differences in every device and tests started to fail so let's just merge it for now :D

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Greeter/LoginList.qml'
2--- Greeter/LoginList.qml 2013-02-20 10:46:01 +0000
3+++ Greeter/LoginList.qml 2013-03-18 21:12:21 +0000
4@@ -152,9 +152,12 @@
5 leftMargin: units.gu(2)
6 verticalCenter: parent.verticalCenter
7 verticalCenterOffset: parent.itemOffset
8+ right: parent.right
9+ rightMargin: units.gu(2)
10 }
11 text: name
12 color: "white"
13+ elide: Text.ElideRight
14 }
15
16 MouseArea {

Subscribers

People subscribed via source and target branches