Merge lp:~mzanetti/unity-mir/expose-appimage-sourceSize into lp:unity-mir

Proposed by Michael Zanetti
Status: Merged
Approved by: Gerry Boland
Approved revision: 181
Merged at revision: 193
Proposed branch: lp:~mzanetti/unity-mir/expose-appimage-sourceSize
Merge into: lp:unity-mir
Diff against target: 11 lines (+1/-0)
1 file modified
src/modules/Unity/Application/ApplicationImage.qml (+1/-0)
To merge this branch: bzr merge lp:~mzanetti/unity-mir/expose-appimage-sourceSize
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Michał Sawicz Approve
Review via email: mp+207626@code.launchpad.net

Commit message

expose ApplicationImage's sourceSize

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

https://code.launchpad.net/~mzanetti/unity8/keep-appImage-aspect-ratio/+merge/207627

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

 * If you changed the UI, has there been a design review?

N/A

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

Please.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

• Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
• Did CI run pass? If not, please explain why.
Is fine

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/modules/Unity/Application/ApplicationImage.qml'
2--- src/modules/Unity/Application/ApplicationImage.qml 2013-10-01 17:45:26 +0000
3+++ src/modules/Unity/Application/ApplicationImage.qml 2014-02-21 11:27:51 +0000
4@@ -20,6 +20,7 @@
5 id: root
6 property var source: null
7 readonly property bool ready: source && (image.status == Image.Ready)
8+ property alias sourceSize: image.sourceSize
9
10 function scheduleUpdate() {
11 image.source = "";

Subscribers

People subscribed via source and target branches