Merge lp:~mzanetti/unity-api/private-quicklist-entries into lp:unity-api

[Michael Zanetti]

Add RoleIsPrivate to launcher's quicklist model api

Related: https://code.launchpad.net/~mzanetti/unity8/stripped-down-quicklist/+merge/318219

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:277
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/145/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4205
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4233
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4067
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4067/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4067
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4067/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4067
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4067/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4067
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4067/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4067
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4067/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4067
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4067/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/145/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

Q_ENUMS is "bad" use Q_ENUM

review: Needs Fixing

[lp:~mzanetti/unity-api/private-quicklist-entries]

278. By Michael Zanetti on 2017-02-27

Q_ENUMS -> Q_ENUM

[Michael Zanetti (mzanetti)]

> Q_ENUMS is "bad" use Q_ENUM

oops, yeah, fixed

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:278
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/146/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4218
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4246
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4081
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4081/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4081
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4081/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4081
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4081/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4081
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4081/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4081
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4081/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4081
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4081/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/146/rebuild

review: Approve (continuous-integration)

[lp:~mzanetti/unity-api/private-quicklist-entries]

279. By Michael Zanetti on 2017-02-27

add some comment about the new role

[Albert Astals Cid (aacid)]

Looks good

review: Approve

[Daniel d'Andrada (dandrader)]

In debian/changelog:

"""
+unity-api (8.5) zesty; urgency=medium
"""

Please next time use UNRELEASED instead of zesty. Besides being the correct state to be in, it also makes debchange work correcly. So that instead of debchange adding a new release on top of this one it will append to it instead and reformat for it to be per-author (in case they differ).

[Daniel d'Andrada (dandrader)]

Just run into this issue as I was rebasing a branch of mine on top of this one.

=== modified file 'debian/changelog'
--- debian/changelog	2017-02-23 11:22:38 +0000
+++ debian/changelog	2017-02-27 11:42:12 +0000
@@ -1,3 +1,10 @@
+unity-api (8.5) zesty; urgency=medium
+
+  [ Michael Zanetti ]
+  * Add RoleIsPrivate to launcher's quicklist entries
+
+ -- Michael Zanetti <[e-mail]>  Fri, 24 Feb 2017 13:57:12 +0000
+
 unity-api (8.4+17.04.20170223-0ubuntu1) zesty; urgency=medium
 
   [ Pete Woods ]

=== modified file 'include/unity/shell/launcher/CMakeLists.txt'
--- include/unity/shell/launcher/CMakeLists.txt	2016-11-30 10:43:52 +0000
+++ include/unity/shell/launcher/CMakeLists.txt	2017-02-27 11:42:12 +0000
@@ -7,7 +7,7 @@
 
 set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
 
-set(VERSION 11)
+set(VERSION 12)
 set(PKGCONFIG_NAME "unity-shell-launcher")
 set(PKGCONFIG_DESCRIPTION "Unity shell Launcher APIs")
 set(PKGCONFIG_REQUIRES "Qt5Core")

=== modified file 'include/unity/shell/launcher/QuickListModelInterface.h'
--- include/unity/shell/launcher/QuickListModelInterface.h	2016-12-14 15:57:28 +0000
+++ include/unity/shell/launcher/QuickListModelInterface.h	2017-02-27 11:42:12 +0000
@@ -39,6 +39,7 @@
   * - RoleIcon (icon): The icon to be shown for this entry (QString).
   * - RoleClickable (clickable): Determines if the entry can be triggered or is just a static text (boolean)
   * - RoleHasSeparator (hasSeparator): Determines if the entry has a separator (boolean)
+  * - RoleIsPrivate (isPrivate): Determines whether the entry should be shown or not in locked mode (e.g. greeter is locked)
   */
 class UNITY_API QuickListModelInterface: public QAbstractListModel
 {
@@ -51,6 +52,7 @@
         m_roleNames.insert(RoleIcon, "icon");
         m_roleNames.insert(RoleClickable, "clickable");
         m_roleNames.insert(RoleHasSeparator, "hasSeparator");
+        m_roleNames.insert(RoleIsPrivate, "isPrivate");
     }
     /// @endcond
 public:
@@ -63,8 +65,10 @@
         RoleLabel,
         RoleIcon,
         RoleClickable,
-        RoleHasSeparator
+        RoleHasSeparator,
+        RoleIsPrivate
     };
+    Q_ENUM(Roles)
 
     /// @cond
     virtual ~QuickListModelInterface() {}

=== modified file 'test/qmltest/mocks/plugins/Unity/Launcher/Mocks/MockQuickListModel.cpp'
--- test/qmltest/mocks/plugins/Unity/Launcher/Mocks/MockQuickListModel.cpp	2016-10-28 11:14:37 +0000
+++ test/qmltest/mocks/plugins/Unity/Launcher/Mocks/MockQuickListModel.cpp	2017-02-27 11:42:12 +0000
@@ -39,6 +39,8 @@
         return true;
     case RoleHasSeparator:
         return true;
+    case RoleIsPrivate:
+        return false;
     }
     return QVariant();
 }

=== modified file 'test/qmltest/unity/shell/launcher/tst_Launcher.qml'
--- test/qmltest/unity/shell/launcher/tst_Launcher.qml	2016-11-30 10:38:23 +0000
+++ test/qmltest/unity/shell/launcher/tst_Launcher.qml	2017-02-27 11:42:12 +0000
@@ -175,7 +175,8 @@
                 { tag: "Model.roles[label]", role: "label", type: "string" },
                 { tag: "Model.roles[icon]", role: "icon", type: "string" },
                 { tag: "Model.roles[clickable]", role: "clickable", type: "boolean" },
-                { tag: "Model.roles[hasSeparator]", role: "hasSeparator", type: "boolean" }
+                { tag: "Model.roles[hasSeparator]", role: "hasSeparator", type: "boolean" },
+                { tag: "Model.roles[isPrivate]", role: "isPrivate", type: "boolean" }
             ];
         }