Code review comment for lp:~mzanetti/ubuntu-ui-toolkit/expanding-listitem

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Hey, some functional issues:
- There seem to be two thin dividers visible, and they get out of sync when dragging the view slowly (http://ubuntuone.com/5Rgpeq2ZpYCP8brP9Xc6lS)
- Did you confirm the dragging behaviours with UX design? Are you supposed to be able to drag when an item is expanded at all? Shouldn't it collapse as soon as you touch outside?
- Scrollable expanded items overlay the divider (http://ubuntuone.com/4DKYhOoTb5H2XwNHYPVEhp)

Wonder if it'd make sense to have a more real-life example in the gallery, where you'd have one ExpandablesColumn or ExpandablesListView covering the whole view - would be easier to see the behaviours.

Also, One thing that happened for me repeatedly - when tapping on one of the faded-out items, I expected it to expand straight away, not only collapse the current item - something worth exploring with UX design.

review: Needs Fixing

« Back to merge proposal