Merge lp:~mzanetti/ubuntu-system-settings/only-animate-when-visible into lp:ubuntu-system-settings

[Michael Zanetti]

Only animate ActivityIndicators when they are visible

This reduces CPU usage when in the Bluetooth page a lot.

[Ken VanDine (ken-vandine)]

Looks great

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1550
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/2468/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5031
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-amd64-ci/243
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/652
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/4041
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5028
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5028/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24955

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/2468/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'plugins/bluetooth/PageComponent.qml'
--- plugins/bluetooth/PageComponent.qml	2015-09-18 14:18:11 +0000
+++ plugins/bluetooth/PageComponent.qml	2015-11-05 12:58:46 +0000
@@ -205,7 +205,7 @@
                             topMargin: units.gu(1)
                         }
                         visible: backend.powered && !backend.discoverable
-                        running: true
+                        running: visible
                     }
                 }
             }
@@ -237,7 +237,7 @@
                         text: getDisplayName(type, displayName)
                         control: ActivityIndicator {
                             visible: connection == Device.Connecting
-                            running: true
+                            running: visible
                         }
                         onClicked: {
                             backend.setSelectedDevice(addressName);
@@ -256,7 +256,7 @@
                 enabled: bluetoothActionGroup.enabled
                 control: ActivityIndicator {
                     visible: backend.powered && backend.discovering
-                    running: true
+                    running: visible
                 }
             }