Merge lp:~mzanetti/ubuntu-clock-app/reboot-packaging into lp:~dholbach/ubuntu-clock-app/reboot-packaging

Proposed by Michael Zanetti
Status: Merged
Merge reported by: Daniel Holbach
Merged at revision: not available
Proposed branch: lp:~mzanetti/ubuntu-clock-app/reboot-packaging
Merge into: lp:~dholbach/ubuntu-clock-app/reboot-packaging
Diff against target: 14 lines (+3/-3)
1 file modified
tests/autopilot/CMakeLists.txt (+3/-3)
To merge this branch: bzr merge lp:~mzanetti/ubuntu-clock-app/reboot-packaging
Reviewer Review Type Date Requested Status
Daniel Holbach Needs Fixing
Review via email: mp+230513@code.launchpad.net

Commit message

don't force python3. For some reason that seems to fail with qtcreator

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Hum... now I get this:

-- Detecting CXX compiler ABI info - done
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named distutils.sysconfig
CMake Error at tests/autopilot/CMakeLists.txt:5 (install):
  install DIRECTORY given no DESTINATION!

-- Configuring incomplete, errors occurred!

review: Needs Fixing
Revision history for this message
Michael Zanetti (mzanetti) wrote :

> Hum... now I get this:
>
> -- Detecting CXX compiler ABI info - done
> Traceback (most recent call last):
> File "<string>", line 1, in <module>
> ImportError: No module named distutils.sysconfig
> CMake Error at tests/autopilot/CMakeLists.txt:5 (install):
> install DIRECTORY given no DESTINATION!
>
>
> -- Configuring incomplete, errors occurred!

Interesting... This is exactly what I get without this change here. How are you running cmake?

Revision history for this message
Michael Zanetti (mzanetti) wrote :

ah no... sorry... Its a bit different... I don't get the distutils.sysconfig import error. But forcing python3 here doesn't seem to return anything. (In qtcreators click chroot, that is)

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

On testing, it runs fine on desktop. However on the device, it fails due to failed event. I am not sure why. It creates the click packages and installs on the device. However when trying to launch on the device, the loading screen with the three dots is shown and then it closes immediately. I think there are some other cmake issues here.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Do note this is not localised to this branch, I see the same thing in the parent reboot-packaging branch as well :/

Revision history for this message
Daniel Holbach (dholbach) wrote :

Ok. So this branch is merged, but still we need to fix this - with the new approach, the package build (CLICK_MODE=OFF) fails as well.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/CMakeLists.txt'
2--- tests/autopilot/CMakeLists.txt 2014-08-08 15:57:16 +0000
3+++ tests/autopilot/CMakeLists.txt 2014-08-12 16:33:57 +0000
4@@ -1,7 +1,7 @@
5-execute_process(COMMAND python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
6- OUTPUT_VARIABLE PYTHON_PACKAGE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
7+if(INSTALL_TESTS)
8+ execute_process(COMMAND python -c "from distutils.sysconfig import get_python_lib; print get_python_lib()"
9+ OUTPUT_VARIABLE PYTHON_PACKAGE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
10
11-if(INSTALL_TESTS)
12 install(DIRECTORY ${AUTOPILOT_DIR}
13 DESTINATION ${PYTHON_PACKAGE_DIR}
14 )

Subscribers

People subscribed via source and target branches