Ubuntu Notes app

Merge lp:~mzanetti/reminders-app/translate-untitled into lp:reminders-app

  1. translate-untitled
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 339
Merged at revision: 340
Proposed branch: lp:~mzanetti/reminders-app/translate-untitled
Merge into: lp:reminders-app
Diff against target: 11 lines (+1/-1)
1 file modified
src/app/qml/components/PageWithBottomEdge.qml (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/translate-untitled
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+249577@code.launchpad.net

Commit message

make "Untitle" translatable

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:339
http://91.189.93.70:8080/job/reminders-app-ci/645/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1058
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1058/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/66

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/645/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM.

review: Approve
Revision history for this message
David Planella (dpm) wrote :

Thanks! This will need an additional .pot file update for the fix to take effect. As it's been merged already, it could be taken care of in another branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/components/PageWithBottomEdge.qml'
2--- src/app/qml/components/PageWithBottomEdge.qml 2014-12-14 22:31:00 +0000
3+++ src/app/qml/components/PageWithBottomEdge.qml 2015-02-12 22:05:58 +0000
4@@ -120,7 +120,7 @@
5 edgeLoader.item.ready()
6
7
8- NotesStore.createNote("Untitled", filterNotebookGuid);
9+ NotesStore.createNote(i18n.tr("Untitled"), filterNotebookGuid);
10 }
11 }
12

Subscribers

People subscribed via source and target branches