Merge lp:~mzanetti/reminders-app/that-darn-focus into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 417
Merged at revision: 425
Proposed branch: lp:~mzanetti/reminders-app/that-darn-focus
Merge into: lp:reminders-app
Diff against target: 25 lines (+2/-1)
2 files modified
src/app/qml/components/RtfButton.qml (+1/-0)
src/app/qml/ui/EditNoteView.qml (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/that-darn-focus
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+257554@code.launchpad.net

Commit message

Take the focus on closing for real

To post a comment you must log in.
417. By Michael Zanetti

merge trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Yup, that works.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/components/RtfButton.qml'
2--- src/app/qml/components/RtfButton.qml 2015-04-09 17:49:40 +0000
3+++ src/app/qml/components/RtfButton.qml 2015-04-27 17:34:23 +0000
4@@ -29,6 +29,7 @@
5 property string color: "transparent"
6 property alias iconColor: icon.color
7 property alias horizontalAlignment: textField.horizontalAlignment
8+ property alias activeFocusOnPress: mouseArea.activeFocusOnPress
9
10 property alias font: textField.font
11
12
13=== modified file 'src/app/qml/ui/EditNoteView.qml'
14--- src/app/qml/ui/EditNoteView.qml 2015-04-09 17:49:40 +0000
15+++ src/app/qml/ui/EditNoteView.qml 2015-04-27 17:34:23 +0000
16@@ -628,8 +628,8 @@
17 text: i18n.tr("Done")
18 height: parent.height
19 iconColor: UbuntuColors.green
20+ activeFocusOnPress: true
21 onClicked: {
22- noteTextArea.focus = false;
23 saveNote();
24 root.exitEditMode(root.note);
25 }

Subscribers

People subscribed via source and target branches