Merge lp:~mzanetti/reminders-app/textarea into lp:reminders-app

Proposed by Michael Zanetti
Status: Rejected
Rejected by: Michael Zanetti
Proposed branch: lp:~mzanetti/reminders-app/textarea
Merge into: lp:reminders-app
Diff against target: 27 lines (+5/-3)
1 file modified
src/app/qml/ui/EditNoteView.qml (+5/-3)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/textarea
Reviewer Review Type Date Requested Status
Ubuntu Notes app developers Pending
Review via email: mp+253286@code.launchpad.net

Commit message

Switch to uitk's TextArea

Description of the change

WARNING: This depends on a not yet merged branch in UITK. Also it will introduce a dependency to Framework 15.04 when merged.

Also I hope to get rid of the "+ units.gu(2)" in line 13 as IMO that should be taken into account by the TextArea's paintedHeight property.

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

this change was done with another branch

Unmerged revisions

384. By Michael Zanetti

switch to uitk's TextArea

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/EditNoteView.qml'
2--- src/app/qml/ui/EditNoteView.qml 2015-03-05 18:23:25 +0000
3+++ src/app/qml/ui/EditNoteView.qml 2015-03-17 22:17:13 +0000
4@@ -174,18 +174,20 @@
5 values: Notebooks {}
6 }
7
8- TextEdit {
9+ TextArea {
10 id: noteTextArea
11 width: flick.width
12- height: Math.max(flick.height - notebookSelector.height, paintedHeight)
13+ height: Math.max(flick.height - notebookSelector.height, paintedHeight + units.gu(2))
14 focus: true
15 wrapMode: TextEdit.Wrap
16 textFormat: TextEdit.RichText
17 text: root.note ? root.note.richTextContent : ""
18 onCursorRectangleChanged: flick.ensureVisible(cursorRectangle)
19 selectByMouse: toolbox.charFormatExpanded
20- textMargin: units.gu(1)
21 selectionColor: UbuntuColors.blue
22+ style: TextAreaStyle {
23+ background: null
24+ }
25
26 // Due to various things updating when creating the view,
27 // we need to set the focus in the next event loop pass

Subscribers

People subscribed via source and target branches