Merge lp:~mzanetti/reminders-app/tags-rider into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 371
Merged at revision: 371
Proposed branch: lp:~mzanetti/reminders-app/tags-rider
Merge into: lp:reminders-app
Diff against target: 28 lines (+5/-6)
1 file modified
src/app/qml/ui/TagsPage.qml (+5/-6)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/tags-rider
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+251816@code.launchpad.net

Commit message

use the knight rider indicator for the tags page too

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Ops, we totally lost it when we implemented tags page.. Good catch!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/TagsPage.qml'
2--- src/app/qml/ui/TagsPage.qml 2015-03-04 00:23:45 +0000
3+++ src/app/qml/ui/TagsPage.qml 2015-03-04 19:50:00 +0000
4@@ -102,12 +102,6 @@
5 }
6 }
7
8- ActivityIndicator {
9- anchors.centerIn: parent
10- running: tags.loading
11- visible: running
12- }
13-
14 Scrollbar {
15 flickableItem: parent
16 }
17@@ -120,6 +114,11 @@
18 }
19 }
20
21+ BouncingProgressBar {
22+ anchors.top: parent.top
23+ visible: tags.loading
24+ }
25+
26 Label {
27 anchors.centerIn: parent
28 visible: !tags.loading && tagsListView.count == 0

Subscribers

People subscribed via source and target branches