Merge lp:~mzanetti/reminders-app/suppress-warnings into lp:reminders-app

[Michael Zanetti]

suppress some warnings

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:271
http://91.189.93.70:8080/job/reminders-app-ci/549/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/841
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/841/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/245

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/549/rebuild

review: Needs Fixing (continuous-integration)

[Riccardo Padovani (rpadovani)]

Doesn't suppress all warnings but it's definitely an improvement! Thanks

Some warnings I have:

file:///home/rpadovani/Documents/ubuntu/touch/core-apps/reminders-app/suppress-warnings/builddir/src/app/qml/ui/NotesPage.qml:122: TypeError: Cannot read property 'reminder' of null
file:///home/rpadovani/Documents/ubuntu/touch/core-apps/reminders-app/suppress-warnings/builddir/src/app/qml/ui/NotesPage.qml:118: TypeError: Cannot read property 'reminder' of null

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'po/com.ubuntu.reminders.pot'
--- po/com.ubuntu.reminders.pot	2014-10-09 16:42:14 +0000
+++ po/com.ubuntu.reminders.pot	2014-10-10 11:00:01 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2014-10-09 18:42+0200\n"
+"POT-Creation-Date: 2014-10-10 12:50+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"
@@ -137,7 +137,7 @@
 msgid "Add note"
 msgstr ""
 
-#: src/app/qml/ui/NotesPage.qml:207
+#: src/app/qml/ui/NotesPage.qml:206
 msgid ""
 "No notes available. You can create new notes using the \"Add note\" button."
 msgstr ""

=== modified file 'src/app/qml/ui/NoteView.qml'
--- src/app/qml/ui/NoteView.qml	2014-09-27 11:05:10 +0000
+++ src/app/qml/ui/NoteView.qml	2014-10-10 11:00:01 +0000
@@ -24,19 +24,20 @@
 
 Item {
     id: root
-    property string title: note.title
-    property var note
+    property string title: note ? note.title : ""
+    property var note: null
 
     signal editNote(var note)
 
     onNoteChanged: {
-        print("refreshing note:", root.note.guid)
-        NotesStore.refreshNoteContent(root.note.guid)
+        if (root.note != null) {
+            NotesStore.refreshNoteContent(root.note.guid)
+        }
     }
 
     BouncingProgressBar {
         anchors.top: parent.top
-        visible: root.note.loading
+        visible: root.note == null || root.note.loading
         z: 10
     }
 
@@ -55,7 +56,7 @@
         id: noteTextArea
         anchors { fill: parent}
 
-        property string html: note.htmlContent
+        property string html: root.note ? note.htmlContent : ""
 
         onHtmlChanged: {
             loadHtml(html, "file:///")
@@ -66,7 +67,7 @@
         preferences.minimumFontSize: 14
 
         Connections {
-            target: note
+            target: note ? note : null
             onResourcesChanged: {
                 noteTextArea.loadHtml(noteTextArea.html, "file:///")
             }