Merge lp:~mzanetti/reminders-app/section-separator into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 557
Merged at revision: 557
Proposed branch: lp:~mzanetti/reminders-app/section-separator
Merge into: lp:reminders-app
Diff against target: 21 lines (+8/-2)
1 file modified
src/app/qml/ui/NotesPage.qml (+8/-2)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/section-separator
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+293622@code.launchpad.net

Commit message

Add a separator to section headers

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Looks great, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/NotesPage.qml'
2--- src/app/qml/ui/NotesPage.qml 2016-04-30 21:32:48 +0000
3+++ src/app/qml/ui/NotesPage.qml 2016-05-03 13:27:25 +0000
4@@ -215,9 +215,15 @@
5 }
6 section.property: root.sortOrderToString(notes.sortOrder);
7
8- section.delegate: Empty {
9+ section.delegate: ListItem {
10 height: units.gu(5)
11- showDivider: false
12+ Rectangle {
13+ anchors { left: parent.left; top: parent.top; right: parent.right }
14+ height: units.dp(1)
15+ color: theme.palette.normal.base
16+ visible: index > 0
17+ }
18+
19 RowLayout {
20 anchors { left: parent.left; right: parent.right; verticalCenter: parent.verticalCenter; margins: units.gu(1) }
21 Label {

Subscribers

People subscribed via source and target branches