Merge lp:~mzanetti/reminders-app/scrollbars into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 301
Merged at revision: 305
Proposed branch: lp:~mzanetti/reminders-app/scrollbars
Merge into: lp:reminders-app
Diff against target: 56 lines (+14/-0)
4 files modified
src/app/qml/ui/NotebooksPage.qml (+3/-0)
src/app/qml/ui/NotesPage.qml (+4/-0)
src/app/qml/ui/RemindersPage.qml (+4/-0)
src/app/qml/ui/TagsPage.qml (+3/-0)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/scrollbars
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+241151@code.launchpad.net

Commit message

add scrollbars to listviews

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Tested, works as expected, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/NotebooksPage.qml'
2--- src/app/qml/ui/NotebooksPage.qml 2014-09-26 14:43:32 +0000
3+++ src/app/qml/ui/NotebooksPage.qml 2014-11-07 22:24:58 +0000
4@@ -156,6 +156,9 @@
5 text: notebooks.error
6 }
7
8+ Scrollbar {
9+ flickableItem: parent
10+ }
11 }
12
13 Item {
14
15=== modified file 'src/app/qml/ui/NotesPage.qml'
16--- src/app/qml/ui/NotesPage.qml 2014-11-06 11:26:30 +0000
17+++ src/app/qml/ui/NotesPage.qml 2014-11-07 22:24:58 +0000
18@@ -214,5 +214,9 @@
19 horizontalAlignment: Text.AlignHCenter
20 text: notes.error ? notes.error : i18n.tr("No notes available. You can create new notes using the \"Add note\" button.")
21 }
22+
23+ Scrollbar {
24+ flickableItem: parent
25+ }
26 }
27 }
28
29=== modified file 'src/app/qml/ui/RemindersPage.qml'
30--- src/app/qml/ui/RemindersPage.qml 2014-11-06 18:40:07 +0000
31+++ src/app/qml/ui/RemindersPage.qml 2014-11-07 22:24:58 +0000
32@@ -111,6 +111,10 @@
33 text: notes.error ? notes.error :
34 i18n.tr("No reminders available. You can create new reminders by setting a reminder when viewing a note.")
35 }
36+
37+ Scrollbar {
38+ flickableItem: parent
39+ }
40 }
41 }
42 }
43
44=== modified file 'src/app/qml/ui/TagsPage.qml'
45--- src/app/qml/ui/TagsPage.qml 2014-10-10 14:11:44 +0000
46+++ src/app/qml/ui/TagsPage.qml 2014-11-07 22:24:58 +0000
47@@ -164,6 +164,9 @@
48 text: tags.error
49 }
50
51+ Scrollbar {
52+ flickableItem: parent
53+ }
54 }
55
56 Label {

Subscribers

People subscribed via source and target branches