Merge lp:~mzanetti/reminders-app/save-note-after-editing-tags into lp:reminders-app

[Michael Zanetti]

Save notes after editing tags via the ListItem action in NotesPage

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:360
http://91.189.93.70:8080/job/reminders-app-ci/680/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2176
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2176/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/282
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/101

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/680/rebuild

review: Approve (continuous-integration)

[Riccardo Padovani (rpadovani)]

Are you sure you want to implement that?

We still have two buttons in the edit mode, one for go discard changes to note and one to save them.

If a user edit the content, then edit the tag, he can't discard changes anymore...

review: Needs Information

[Michael Zanetti (mzanetti)]

> Are you sure you want to implement that?

Quite sure :)

When you set a reminder or tag from the view-only mode, when would you save it if not directly when closing the view?

Without this change it's never saved right now, unless you go to edit mode and press the save button. That's not what we want I'd say.

>
> We still have two buttons in the edit mode, one for go discard changes to note
> and one to save them.

Yeah, I'm probably gonna drop that. I received some feedback from users that the save button feels old-school and should be removed for auto-saving. Most modern apps don't use save/cancel buttons any more, including the Evernote website.

>
> If a user edit the content, then edit the tag, he can't discard changes
> anymore...

I really don't think that's a big problem... It just doesn't happen that you accidentally change a lot of tags and need a "revert" button. You might change one by accident sometimes, but then you can just tap it again to re-select. If you miss that too, you also wouldn't press the cancel button and press the save button instead, because you're not aware of the mistake.

For accidentally deleting a lot of text in the edit view (which could happen indeed) we have an undo button nowadays.

[Riccardo Padovani (rpadovani)]

> > Are you sure you want to implement that?
>
> Quite sure :)
>
> When you set a reminder or tag from the view-only mode, when would you save it
> if not directly when closing the view?
>
> Without this change it's never saved right now, unless you go to edit mode and
> press the save button. That's not what we want I'd say.

This make sense

> > We still have two buttons in the edit mode, one for go discard changes to
> note
> > and one to save them.
>
> Yeah, I'm probably gonna drop that. I received some feedback from users that
> the save button feels old-school and should be removed for auto-saving. Most
> modern apps don't use save/cancel buttons any more, including the Evernote
> website.

I totally agree on this, the only concern I have it's about the transition time: we will have the note save when you edit a tag, and the save when you exit the note.
It's a strange mix.

Anyway, I'm going to approve this.

> >
> > If a user edit the content, then edit the tag, he can't discard changes
> > anymore...
>
> I really don't think that's a big problem... It just doesn't happen that you
> accidentally change a lot of tags and need a "revert" button. You might change
> one by accident sometimes, but then you can just tap it again to re-select. If
> you miss that too, you also wouldn't press the cancel button and press the
> save button instead, because you're not aware of the mistake.
>
> For accidentally deleting a lot of text in the edit view (which could happen
> indeed) we have an undo button nowadays.

Makes sense.

review: Approve

=== modified file 'src/app/qml/components/EditTagsDialog.qml'
--- src/app/qml/components/EditTagsDialog.qml	2014-12-14 04:07:07 +0000
+++ src/app/qml/components/EditTagsDialog.qml	2015-02-27 22:44:33 +0000
@@ -29,6 +29,8 @@
     property var note
     property int pageHeight
 
+    signal done();
+
     Tags {
         id: tags
     }
@@ -117,6 +119,9 @@
 
         text: i18n.tr("Done")
 
-        onClicked: PopupUtils.close(root)
+        onClicked: {
+            root.done();
+            PopupUtils.close(root)
+        }
     }
 }

=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml	2015-02-25 22:48:18 +0000
+++ src/app/qml/ui/NotesPage.qml	2015-02-27 22:44:33 +0000
@@ -203,8 +203,9 @@
                 pageStack.push(Qt.resolvedUrl("SetReminderPage.qml"), { note: NotesStore.note(model.guid) });
             }
             onEditTags: {
-                PopupUtils.open(Qt.resolvedUrl("../components/EditTagsDialog.qml"), root,
+                var popup = PopupUtils.open(Qt.resolvedUrl("../components/EditTagsDialog.qml"), root,
                                 { note: NotesStore.note(model.guid), pageHeight: root.height });
+                popup.done.connect(function() { NotesStore.saveNote(popup.note.guid)})
             }
         }