Merge lp:~mzanetti/reminders-app/run_on_device into lp:reminders-app

Proposed by Michael Zanetti
Status: Superseded
Proposed branch: lp:~mzanetti/reminders-app/run_on_device
Merge into: lp:reminders-app
Prerequisite: lp:~mzanetti/reminders-app/integrate-plugin
Diff against target: 0 lines
To merge this branch: bzr merge lp:~mzanetti/reminders-app/run_on_device
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
David Planella Needs Fixing
Review via email: mp+196400@code.launchpad.net

This proposal has been superseded by a proposal from 2013-11-25.

Commit message

add run_on_ubuntu_touch.sh script

Description of the change

This adds a script "run_on_ubuntu_touch.sh" which can be used to directly compile and run the app on the phone.

** You need to have the device in rw mode **

Once (rather every time you reflash) you need to setup the build environment on the phone with:

./run_on_ubuntu_touch.sh -s

After this you can just run the app with

./run_on_ubuntu_touch.sh

To create a click package for uploading to the store, use:

./run_on_ubuntu_touch.sh -c

The click package will be built on the phone and downloaded to the PC.

Additionally this branch fixes the .desktop file to be working with click packaging.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
18. By Michael Zanetti

fix apparmor policy to allow accessing accounts

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Looks good to me, thanks!

Just two small nitpicks:

1) Could you add the license header to the .sh file?

2) 23 +Comment=Ubuntu Evernote client

Evernote have asked us not to call the app an Evernote client until they've reviewed the first stable version. Would you mind changing the comment to something along these lines?

"Ubuntu Reminders app, powered by Evernote"

review: Needs Fixing
19. By Michael Zanetti

--Evernote, ++Reminders

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> Looks good to me, thanks!
>
> Just two small nitpicks:
>
> 1) Could you add the license header to the .sh file?

Actually we are lacking license headers everywhere... I'll do a separete MR adding those.

>
> 2) 23 +Comment=Ubuntu Evernote client
>
> Evernote have asked us not to call the app an Evernote client until they've
> reviewed the first stable version. Would you mind changing the comment to
> something along these lines?
>
> "Ubuntu Reminders app, powered by Evernote"

fixed.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
20. By Michael Zanetti

revert change in NotesPage.qml

Unmerged revisions

Preview Diff

Empty

Subscribers

People subscribed via source and target branches