Merge lp:~mzanetti/reminders-app/remove-sorting-close-button into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 384
Merged at revision: 385
Proposed branch: lp:~mzanetti/reminders-app/remove-sorting-close-button
Merge into: lp:reminders-app
Diff against target: 18 lines (+2/-5)
1 file modified
src/app/qml/components/SortingDialog.qml (+2/-5)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/remove-sorting-close-button
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+253296@code.launchpad.net

Commit message

remove close button from sorting dialog

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/components/SortingDialog.qml'
2--- src/app/qml/components/SortingDialog.qml 2015-02-21 14:13:29 +0000
3+++ src/app/qml/components/SortingDialog.qml 2015-03-17 23:33:54 +0000
4@@ -33,12 +33,9 @@
5 i18n.tr("Title (ascending)"),
6 i18n.tr("Title (descending)")
7 ]
8- }
9
10- Button {
11- text: i18n.tr("Close")
12- onClicked: {
13- root.sortOrder = optionSelector.selectedIndex
14+ onDelegateClicked: {
15+ root.sortOrder = index
16 root.accepted();
17 PopupUtils.close(dialog);
18 }

Subscribers

People subscribed via source and target branches