Merge lp:~mzanetti/reminders-app/no-2-cols-on-flo into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 517
Merged at revision: 516
Proposed branch: lp:~mzanetti/reminders-app/no-2-cols-on-flo
Merge into: lp:reminders-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/app/qml/Reminders.qml (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/no-2-cols-on-flo
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+278129@code.launchpad.net

Commit message

workaround to disable the buggy two column mode on nexus 7 for now.

The whole 2-column logic currently is a self-made thing that is
subject to be replaced with the AdaptivePageLayout from the UITK.

Description of the change

workaround to disable the buggy two column mode on nexus 7 for now.

The whole 2-column logic currently is a self-made thing that is
subject to be replaced with the AdaptivePageLayout from the UITK.

To post a comment you must log in.
517. By Michael Zanetti

bump it to 140.

Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

LGTM

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/Reminders.qml'
2--- src/app/qml/Reminders.qml 2015-11-02 20:26:37 +0000
3+++ src/app/qml/Reminders.qml 2015-11-20 11:12:08 +0000
4@@ -37,7 +37,7 @@
5 objectName: "mainView"
6 applicationName: "com.ubuntu.reminders"
7
8- property bool narrowMode: root.width < units.gu(80)
9+ property bool narrowMode: root.width < units.gu(140)
10 property var uri: undefined
11
12 onNarrowModeChanged: {

Subscribers

People subscribed via source and target branches