Merge lp:~mzanetti/reminders-app/needsContentSync into lp:reminders-app
Proposed by
Michael Zanetti
Status: | Merged |
---|---|
Approved by: | Riccardo Padovani |
Approved revision: | 359 |
Merged at revision: | 359 |
Proposed branch: | lp:~mzanetti/reminders-app/needsContentSync |
Merge into: | lp:reminders-app |
Prerequisite: | lp:~mzanetti/reminders-app/better-reset-connection |
Diff against target: |
197 lines (+58/-30) 3 files modified
src/libqtevernote/jobs/savenotejob.cpp (+32/-29) src/libqtevernote/note.cpp (+24/-1) src/libqtevernote/note.h (+2/-0) |
To merge this branch: | bzr merge lp:~mzanetti/reminders-app/needsContentSync |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Riccardo Padovani | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email:
|
Commit message
Don't send the note content to the server if it hasn't changed.
This avoids long saving times for notes with big content/attachment when only changing it's reminder or tags.
To post a comment you must log in.
PASSED: Continuous integration, rev:359 91.189. 93.70:8080/ job/reminders- app-ci/ 679/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2175 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2175/artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/reminders- app-utopic- amd64-ci/ 281 91.189. 93.70:8080/ job/reminders- app-vivid- amd64-ci/ 100
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/reminders- app-ci/ 679/rebuild
http://