Merge lp:~mzanetti/reminders-app/improve-error-handling into lp:reminders-app
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Riccardo Padovani | ||||||||
Approved revision: | 388 | ||||||||
Merged at revision: | 389 | ||||||||
Proposed branch: | lp:~mzanetti/reminders-app/improve-error-handling | ||||||||
Merge into: | lp:reminders-app | ||||||||
Prerequisite: | lp:~mzanetti/reminders-app/two-job-queues | ||||||||
Diff against target: |
438 lines (+110/-78) 7 files modified
src/app/qml/components/StatusBar.qml (+1/-0) src/libqtevernote/evernoteconnection.cpp (+39/-1) src/libqtevernote/evernoteconnection.h (+3/-0) src/libqtevernote/jobs/evernotejob.cpp (+9/-5) src/libqtevernote/jobs/fetchnotejob.cpp (+2/-0) src/libqtevernote/notesstore.cpp (+54/-72) src/libqtevernote/notesstore.h (+2/-0) |
||||||||
To merge this branch: | bzr merge lp:~mzanetti/reminders-app/improve-error-handling | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Riccardo Padovani | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+252227@code.launchpad.net |
Commit message
improve some error handling
* Rate limit exceeded
* Upload quota exceeded
* Authentication expired
Description of the change
To test/reproduce the errors:
* Rate limit exceeded
Delete ~/.local/
* Upload quota exceeded
On evernote website, go to account settings, see the quota status. Upload stuff until the quota is reached. Then on the phone, create a note and attach a picture. The app should show the quota warning.
* Authentication expired
With a properly set up account, go to the evernote webbsite -> settings -> applications, and delete the auth for the account. Then do something with the app.
Pleas try to create other error situations and let me know if you manage to get into some error state where we should show something to the user or that is otherwise unhandled correctly.
PASSED: Continuous integration, rev:387 91.189. 93.70:8080/ job/reminders- app-ci/ 710/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2310 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2310/artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/reminders- app-utopic- amd64-ci/ 312 91.189. 93.70:8080/ job/reminders- app-vivid- amd64-ci/ 131
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/reminders- app-ci/ 710/rebuild
http://