Ubuntu Notes app

Merge lp:~mzanetti/reminders-app/fix-tags-crash into lp:reminders-app

  1. fix-tags-crash
  2. Merge into trunk
Proposed by Michael Zanetti on 2015-03-04
Status: Merged
Approved by: Riccardo Padovani on 2015-03-04
Approved revision: 370
Merged at revision: 372
Proposed branch: lp:~mzanetti/reminders-app/fix-tags-crash
Merge into: lp:reminders-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/libqtevernote/notesstore.cpp (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/fix-tags-crash
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve on 2015-03-04
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-03-04
Alan Pope 🍺🐧🐱 🦄 2015-03-04 Approve on 2015-03-04
Review via email: mp+251812@code.launchpad.net

Commit Message

properly parent tags to prevent qml from deleting them

To post a comment you must log in.
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM

review: Approve
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Riccardo Padovani (rpadovani) wrote :

I'm not able to reproduce the bug on vivid. Anyway, change makes sense

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/libqtevernote/notesstore.cpp'
2--- src/libqtevernote/notesstore.cpp 2015-03-04 00:23:45 +0000
3+++ src/libqtevernote/notesstore.cpp 2015-03-04 19:26:26 +0000
4@@ -469,7 +469,7 @@
5
6 Tag* NotesStore::createTag(const QString &name)
7 {
8- Tag *tag = new Tag(QUuid::createUuid().toString().remove(QRegExp("[\{\}]*")), 1);
9+ Tag *tag = new Tag(QUuid::createUuid().toString().remove(QRegExp("[\{\}]*")), 1, this);
10 tag->setName(name);
11 m_tags.append(tag);
12 m_tagsHash.insert(tag->guid(), tag);

Subscribers

People subscribed via source and target branches