Ubuntu Notes app

Merge lp:~mzanetti/reminders-app/fix-sort-init into lp:reminders-app

  1. fix-sort-init
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 374
Merged at revision: 378
Proposed branch: lp:~mzanetti/reminders-app/fix-sort-init
Merge into: lp:reminders-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/libqtevernote/notes.cpp (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/fix-sort-init
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+251850@code.launchpad.net

Commit message

fix initialisation of sortOrder properties

Description of the change

If setting sort order to "created, newest first" the sort order will be wrong at startup because the model's property is set to CreatedNewestFirst while the ctor actually sorts for "updated, newest first".

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:374
http://91.189.93.70:8080/job/reminders-app-ci/697/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2245
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2245/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/299
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/118

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/697/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM

review: Approve
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Lgtm too

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/libqtevernote/notes.cpp'
2--- src/libqtevernote/notes.cpp 2015-02-25 22:45:58 +0000
3+++ src/libqtevernote/notes.cpp 2015-03-04 23:53:24 +0000
4@@ -28,7 +28,7 @@
5 m_onlyReminders(false),
6 m_onlySearchResults(false),
7 m_showDeleted(false),
8- m_sortOrder(SortOrderDateCreatedNewest)
9+ m_sortOrder(SortOrderDateUpdatedNewest)
10 {
11 connect(NotesStore::instance(), &NotesStore::loadingChanged, this, &Notes::loadingChanged);
12 connect(NotesStore::instance(), &NotesStore::errorChanged, this, &Notes::errorChanged);

Subscribers

People subscribed via source and target branches