Merge lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Michael Zanetti
Approved revision: 430
Merged at revision: 431
Proposed branch: lp:~mzanetti/reminders-app/fix-renderwidth
Merge into: lp:reminders-app
Diff against target: 19 lines (+2/-1)
1 file modified
src/app/qml/ui/EditNoteView.qml (+2/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/fix-renderwidth
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+258564@code.launchpad.net

Commit message

Fix setting the note's renderwidth

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

LGTM

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/EditNoteView.qml'
2--- src/app/qml/ui/EditNoteView.qml 2015-04-27 17:24:33 +0000
3+++ src/app/qml/ui/EditNoteView.qml 2015-05-07 21:33:33 +0000
4@@ -37,6 +37,7 @@
5 notebookSelector.selectedIndex = i;
6 }
7 }
8+ note.renderWidth = noteTextArea.width - noteTextArea.textMargin * 2
9 }
10
11 signal exitEditMode(var note)
12@@ -84,7 +85,7 @@
13 target: noteTextArea
14 onWidthChanged: {
15 note.richTextContent = noteTextArea.text;
16- note.renderWidth = noteTextArea.width - noteTextArea.textMargin
17+ note.renderWidth = noteTextArea.width - noteTextArea.textMargin * 2
18 }
19 }
20

Subscribers

People subscribed via source and target branches