Ubuntu Notes app

Merge lp:~mzanetti/reminders-app/fix-oa into lp:reminders-app

  1. fix-oa
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 343
Merged at revision: 346
Proposed branch: lp:~mzanetti/reminders-app/fix-oa
Merge into: lp:reminders-app
Diff against target: 11 lines (+1/-0)
1 file modified
src/account-plugin/qml/evernote/Main.qml.in (+1/-0)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/fix-oa
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+250509@code.launchpad.net

Commit message

fix online account plugin

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:343
http://91.189.93.70:8080/job/reminders-app-ci/660/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2067
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2067/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/81

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/660/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM

review: Approve
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

makes sense, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/account-plugin/qml/evernote/Main.qml.in'
2--- src/account-plugin/qml/evernote/Main.qml.in 2014-09-20 10:52:20 +0000
3+++ src/account-plugin/qml/evernote/Main.qml.in 2015-02-20 21:19:47 +0000
4@@ -30,6 +30,7 @@
5 function completeCreation(reply) {
6 EvernoteConnection.hostname = "@EVERNOTE_HOSTNAME@"
7 EvernoteConnection.token = reply.AccessToken
8+ EvernoteConnection.connectToEvernote();
9 /* At this point the username is getting retrieved. Once that's
10 * done, UserStore will notify that its "username" property has
11 * been changed, and we'll continue from saveUsername(). */

Subscribers

People subscribed via source and target branches