Merge lp:~mzanetti/reminders-app/fix-label-wrapping into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 474
Merged at revision: 475
Proposed branch: lp:~mzanetti/reminders-app/fix-label-wrapping
Merge into: lp:reminders-app
Diff against target: 32 lines (+3/-3)
2 files modified
src/app/qml/components/NotesDelegate.qml (+1/-1)
src/app/qml/components/RemindersDelegate.qml (+2/-2)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/fix-label-wrapping
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265887@code.launchpad.net

Commit message

fix label growing out of place

To post a comment you must log in.
474. By Michael Zanetti

also fix the remindersdelegate

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/components/NotesDelegate.qml'
2--- src/app/qml/components/NotesDelegate.qml 2015-06-14 23:34:29 +0000
3+++ src/app/qml/components/NotesDelegate.qml 2015-07-25 02:42:13 +0000
4@@ -137,7 +137,7 @@
5 text: "<font color=\"" + root.notebookColor + "\">" +
6 Qt.formatDateTime(root.date, Qt.LocalDate) +
7 " </font>" + root.content.replace("\n", " ").trim()
8- wrapMode: Text.WordWrap
9+ wrapMode: Text.WrapAtWordBoundaryOrAnywhere
10 textFormat: Text.StyledText
11 maximumLineCount: 2
12 fontSize: "small"
13
14=== modified file 'src/app/qml/components/RemindersDelegate.qml'
15--- src/app/qml/components/RemindersDelegate.qml 2015-03-15 20:00:21 +0000
16+++ src/app/qml/components/RemindersDelegate.qml 2015-07-25 02:42:13 +0000
17@@ -109,13 +109,13 @@
18 }
19
20 Label {
21- text: note.tagline
22+ text: note.tagline.replace("\n", " ").trim()
23 fontSize: "small"
24 horizontalAlignment: Text.AlignLeft
25 Layout.fillWidth: true
26 maximumLineCount: 2
27 width: parent.width
28- wrapMode: Text.WordWrap
29+ wrapMode: Text.WrapAtWordBoundaryOrAnywhere
30 color: "black"
31 }
32 }

Subscribers

People subscribed via source and target branches