Merge lp:~mzanetti/reminders-app/fix-evernote-reject into lp:reminders-app

Proposed by Michael Zanetti on 2015-02-12
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄 on 2015-02-12
Approved revision: 339
Merged at revision: 341
Proposed branch: lp:~mzanetti/reminders-app/fix-evernote-reject
Merge into: lp:reminders-app
Diff against target: 13 lines (+1/-2)
1 file modified
src/app/qml/reminders.qml (+1/-2)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/fix-evernote-reject
Reviewer Review Type Date Requested Status
Michał Sawicz (community) functional Approve on 2015-02-12
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-02-12
Ubuntu Notes app developers 2015-02-12 Pending
Review via email: mp+249490@code.launchpad.net

Commit Message

don't ask over and over again if the user wants to sync with evernote

Description of the Change

To reproduce, with the current package, delete ~/.config/com.ubuntu.reminders/, also remove all the evernote accounts from OA. Start the app and say no to evernote. Restart the app and will ask again and again.

Here's a click of this branch: http://notyetthere.org/data/com.ubuntu.reminders_0.5.latest_armhf.click

To post a comment you must log in.
Michał Sawicz (saviq) wrote :

Yup.

review: Approve (functional)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/reminders.qml'
2--- src/app/qml/reminders.qml 2015-01-12 20:32:59 +0000
3+++ src/app/qml/reminders.qml 2015-02-12 14:03:42 +0000
4@@ -603,8 +603,7 @@
5 color: UbuntuColors.red
6 onClicked: {
7 PopupUtils.close(noAccount)
8- NotesStore.username = "@local";
9- preferences.haveLocalUser = true;
10+ accountService.startAuthentication("@local", null);
11 }
12 Layout.fillWidth: true
13 }

Subscribers

People subscribed via source and target branches