Ubuntu Notes app

Merge lp:~mzanetti/reminders-app/dont-always-build-translations into lp:reminders-app

  1. dont-always-build-translations
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: David Planella
Approved revision: 308
Merged at revision: 307
Proposed branch: lp:~mzanetti/reminders-app/dont-always-build-translations
Merge into: lp:reminders-app
Diff against target: 12 lines (+1/-1)
1 file modified
po/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/dont-always-build-translations
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
David Planella Needs Fixing
Review via email: mp+241424@code.launchpad.net

Commit message

Don't always build translations

Also renames the target to "translations"

Do "make translations" to update them before doing a release

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Overall LGTM, just a small comment.

review: Needs Fixing
lp:~mzanetti/reminders-app/dont-always-build-translations updated
308. By Michael Zanetti

make it funny

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/CMakeLists.txt'
2--- po/CMakeLists.txt 2014-09-28 08:53:55 +0000
3+++ po/CMakeLists.txt 2014-11-11 15:09:27 +0000
4@@ -5,7 +5,7 @@
5 set(POT_FILE ${DOMAIN}.pot)
6 file(GLOB PO_FILES *.po)
7
8-add_custom_target(${POT_FILE} ALL
9+add_custom_target(pot
10 COMMENT "Generating translation template"
11 COMMAND ${INTLTOOL_EXTRACT} --update --type=gettext/ini
12 --srcdir=${CMAKE_SOURCE_DIR} ${DESKTOP_FILE}.in.in

Subscribers

People subscribed via source and target branches