Ubuntu Notes app

Merge lp:~mzanetti/reminders-app/disable-push-notifications into lp:reminders-app

  1. disable-push-notifications
  2. Merge into trunk
Proposed by Michael Zanetti on 2015-03-05
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄 on 2015-03-05
Approved revision: 374
Merged at revision: 374
Proposed branch: lp:~mzanetti/reminders-app/disable-push-notifications
Merge into: lp:reminders-app
Diff against target: 12 lines (+2/-1)
1 file modified
src/app/qml/reminders.qml (+2/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/disable-push-notifications
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-03-05
Alan Pope 🍺🐧🐱 🦄 2015-03-05 Approve on 2015-03-05
Review via email: mp+251985@code.launchpad.net

Commit Message

disable push notifications for now

We haven't had a chance to properly test and don't want users to run into issues when it gets enabled on the server side.

To post a comment you must log in.
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM

review: Approve
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/reminders.qml'
2--- src/app/qml/reminders.qml 2015-03-04 14:31:29 +0000
3+++ src/app/qml/reminders.qml 2015-03-05 17:04:09 +0000
4@@ -394,7 +394,8 @@
5 target: UserStore
6 onUsernameChanged: {
7 print("Logged in as user:", UserStore.username);
8- registerPushClient();
9+ // Disabling push notifications as we haven't had a chance to properly test that yet
10+ //registerPushClient();
11 }
12 }
13

Subscribers

People subscribed via source and target branches