Merge lp:~mzanetti/reminders-app/bottom-edge-hint into lp:reminders-app

Proposed by Michael Zanetti
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 398
Merged at revision: 403
Proposed branch: lp:~mzanetti/reminders-app/bottom-edge-hint
Merge into: lp:reminders-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/app/qml/ui/NotesPage.qml (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/reminders-app/bottom-edge-hint
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+255240@code.launchpad.net

Commit message

Update the hint on how to create new notes when there are no notes.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Good catch

review: Approve
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Actually, don't you have to update the .pot file too?

review: Needs Information
Revision history for this message
Michael Zanetti (mzanetti) wrote :

> Actually, don't you have to update the .pot file too?

I thought nowadays we do one translation update right before putting out the call for translators. Decreases risk of conflicts between branches.

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Right

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/NotesPage.qml'
2--- src/app/qml/ui/NotesPage.qml 2015-03-31 08:02:43 +0000
3+++ src/app/qml/ui/NotesPage.qml 2015-04-05 10:57:55 +0000
4@@ -251,7 +251,7 @@
5 width: parent.width - units.gu(4)
6 wrapMode: Text.WordWrap
7 horizontalAlignment: Text.AlignHCenter
8- text: i18n.tr("No notes available. You can create new notes using the \"Add note\" button.")
9+ text: i18n.tr("No notes available. You can create new notes by pulling the note editor up from the bottom edge.")
10 }
11
12 Scrollbar {

Subscribers

People subscribed via source and target branches