Merge lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app

[Michael Zanetti]

Add an animation when deleting things

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:454
http://91.189.93.70:8080/job/reminders-app-ci/757/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2929
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2929/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/359
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/179

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/757/rebuild

review: Approve (continuous-integration)

[Riccardo Padovani (rpadovani)]

You forgot reminders page, apart from that, good work!

review: Needs Fixing

[Michael Zanetti (mzanetti)]

Hmm... not so sure about this one any more. Problem is that it seems to mess up the notes list because of the section headers...

[Jenkins Bot (ubuntu-core-apps-jenkins-bot)]

PASSED: Continuous integration, rev:454
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/25/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/108/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/25/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

Putting it to Work in Proress because this triggers a bug in QML in some cases. Better not having the nice animations than breaking sometimes.

TODO: On Qt upgrades of the platform enable this and test if deleting items behaves properly and doesn't mess up the list. Maybe we can land it some day.

Unmerged revisions

454. By Michael Zanetti on 2015-06-14

add an animation when deleting items

=== modified file 'src/app/qml/ui/NotebooksPage.qml'
--- src/app/qml/ui/NotebooksPage.qml	2015-03-15 20:00:21 +0000
+++ src/app/qml/ui/NotebooksPage.qml	2015-06-14 00:36:42 +0000
@@ -116,6 +116,10 @@
                 NotesStore.refreshNotebooks();
             }
 
+            displaced: Transition {
+                UbuntuNumberAnimation { property: "y"}
+            }
+
             delegate: NotebooksDelegate {
                 width: parent.width
                 height: units.gu(10)

=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml	2015-06-11 22:02:25 +0000
+++ src/app/qml/ui/NotesPage.qml	2015-06-14 00:36:42 +0000
@@ -172,6 +172,10 @@
             NotesStore.refreshNotes();
         }
 
+        displaced: Transition {
+            UbuntuNumberAnimation { property: "y"}
+        }
+
         delegate: NotesDelegate {
             title: model.title
             date: notes.sortOrder == Notes.SortOrderUpdatedOldest || notes.sortOrder == Notes.SortOrderUpdatedNewest ?

=== modified file 'src/app/qml/ui/TagsPage.qml'
--- src/app/qml/ui/TagsPage.qml	2015-03-15 20:00:21 +0000
+++ src/app/qml/ui/TagsPage.qml	2015-06-14 00:36:42 +0000
@@ -80,6 +80,10 @@
                 NotesStore.refreshTags();
             }
 
+            displaced: Transition {
+                UbuntuNumberAnimation { property: "y"}
+            }
+
             delegate: TagsDelegate {
                 width: parent.width
                 height: units.gu(10)