Merge lp:~mzanetti/qtcreator-plugin-ubuntu/fix-device_run_app-for-mir into lp:qtcreator-plugin-ubuntu

Proposed by Michael Zanetti
Status: Merged
Approved by: Cris Dywan
Approved revision: 50
Merged at revision: 50
Proposed branch: lp:~mzanetti/qtcreator-plugin-ubuntu/fix-device_run_app-for-mir
Merge into: lp:qtcreator-plugin-ubuntu
Diff against target: 12 lines (+1/-1)
1 file modified
share/qtcreator/ubuntu/scripts/qtc_device_run_app (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/qtcreator-plugin-ubuntu/fix-device_run_app-for-mir
Reviewer Review Type Date Requested Status
Cris Dywan Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+190677@code.launchpad.net

Commit message

make it work on Mir too, no need to hardcode the qpa platform

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Doesn't work for me:

18:37:03] bash: Kann die Prozessgruppe des Terminals nicht setzen (-1).: Das Argument ist ungültig
bash: Keine Job-Steuerung in dieser Shell.
[18:37:03] QXcbConnection: Could not connect to display
[18:37:05] bash: [3802: 3 (255)] tcsetattr: Das Argument ist ungültig

(Cannot set process group of terminal: Invalid argument: bash: No job control in this shell: tcsetattr: Invalid argument)

review: Needs Fixing
Revision history for this message
Cris Dywan (kalikiana) wrote :

Correcting myself: something went wrong before, I re-downloaded the new file from the branch and and copied it in place, and now Build > Touch > Run on Device works quite fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'share/qtcreator/ubuntu/scripts/qtc_device_run_app'
2--- share/qtcreator/ubuntu/scripts/qtc_device_run_app 2013-09-27 15:02:28 +0000
3+++ share/qtcreator/ubuntu/scripts/qtc_device_run_app 2013-10-11 14:06:44 +0000
4@@ -60,7 +60,7 @@
5 # get dbus session addrss from the device
6 DBUS_SESSION_BUS_ADDRESS=`$SSH "cat ~/.cache/upstart/dbus-session|grep DBUS_SESSION_BUS_ADDRESS"`
7
8-COMMAND="export ${DBUS_SESSION_BUS_ADDRESS=}; APP_ID=${APP_ID} qmlscene -platform ubuntu ${TARGET_DEVICE_HOME}/${FOLDERNAME}/${MAIN_QML} --desktop_file_hint=${TARGET_DEVICE_DESKTOP_PATH}/${DESKTOP_FILENAME}"
9+COMMAND="export ${DBUS_SESSION_BUS_ADDRESS=}; APP_ID=${APP_ID} qmlscene ${TARGET_DEVICE_HOME}/${FOLDERNAME}/${MAIN_QML} --desktop_file_hint=${TARGET_DEVICE_DESKTOP_PATH}/${DESKTOP_FILENAME}"
10
11 # make a tar package
12 tar -cjf ${FOLDERNAME}.tar.bz2 ${FOLDERNAME}

Subscribers

People subscribed via source and target branches