Merge lp:~mzanetti/component-store/cleanup-action-on-release into lp:component-store

Proposed by Michael Zanetti on 2015-02-13
Status: Merged
Approved by: Nekhelesh Ramananthan on 2015-02-23
Approved revision: 42
Merged at revision: 42
Proposed branch: lp:~mzanetti/component-store/cleanup-action-on-release
Merge into: lp:component-store
Prerequisite: lp:~mzanetti/component-store/iconSource
Diff against target: 11 lines (+1/-0)
1 file modified
ComponentStore/ListItemWithActions/ListItemWithActions.qml (+1/-0)
To merge this branch: bzr merge lp:~mzanetti/component-store/cleanup-action-on-release
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) 2015-02-17 Approve on 2015-02-23
Ubuntu Touch Community Dev 2015-02-13 Pending
Review via email: mp+249592@code.launchpad.net

Commit message

reset activeAction after executing it

If triggerActionOnMouseRelease is true, and the user activates an action,
all subsequent regular clicks were executed. This cleans up after
executing to prevent this from happening.

To post a comment you must log in.

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ComponentStore/ListItemWithActions/ListItemWithActions.qml'
2--- ComponentStore/ListItemWithActions/ListItemWithActions.qml 2015-02-13 01:02:11 +0000
3+++ ComponentStore/ListItemWithActions/ListItemWithActions.qml 2015-02-13 01:02:11 +0000
4@@ -349,6 +349,7 @@
5 ScriptAction {
6 script: {
7 root.activeAction.triggered(root)
8+ root.activeAction = null
9 mouseArea.state = ""
10 }
11 }

Subscribers

People subscribed via source and target branches