Merge lp:~mzanetti/autopilot-qt/workaround-xpathselect into lp:autopilot-qt

[Michael Zanetti]

also remove . from appname as libxpathselect doesn't like it any more

This makes autopilot work again for apps that need to have an appname like com.canonical.foobar or com.ubuntu.foobar

There are most likely all other special characters affected too. However, in my opinion libxpathselect should be able to process dots and other special chars like it did before, so not spending the effort to find all non working combinations until I'm sure libxpathselect won't be changed to support such app names again.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:42
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-ci/4/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-ci/4/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/4/rebuild

review: Approve (continuous-integration)

[Mathieu Trudel-Lapierre (cyphermox)]

Could you please add integration tests for this?

Thanks!

review: Needs Fixing

[Michael Zanetti (mzanetti)]

Here's a branch that adds full testing to autopilot-qt.

https://code.launchpad.net/~mzanetti/autopilot-qt/add-tests/+merge/153695

However, writing the tests confirmed what I already said in the description: This is only a workaround that tests work again and should be removed again (both, the remove(' ') too).

autopilot-qt itself introspects an app just fine even if there are spaces, dots and whatnot in the app name. Its autopilot itself that has issues with it and for thus I really think such workarounds should be applied to autopilot itself instead of all of their toolkit adaption drivers if the problem is not fixed to allow those characters again.

[Mathieu Trudel-Lapierre (cyphermox)]

Fair enough. As there are no packaging changes and this fixes tests, I'll mark it as Approved.

Can we please link this to a bug though?

review: Approve

[Michael Zanetti (mzanetti)]

> Can we please link this to a bug though?

Done. Also updated the bug report with latest findings on this issue.

=== modified file 'driver/rootnode.cpp'
--- driver/rootnode.cpp	2013-03-04 22:26:53 +0000
+++ driver/rootnode.cpp	2013-03-15 12:52:23 +0000
@@ -39,7 +39,7 @@
 
 std::string RootNode::GetName() const
 {
-    QString appName = application_->applicationName().remove(' ');
+    QString appName = application_->applicationName().remove(' ').remove('.');
     return appName.isEmpty() ? "Root" : appName.toStdString();
 }