Merge lp:~mwhudson/wikkid/missing-404 into lp:wikkid

[Michael Hudson-Doyle]

This branch makes missing pages 404s at the http level.

I add an extension point to the base view to allow the response creation to be customized by a view. There were many things that would have been sufficient for what I needed here, so I went for something pretty simple.

No tests, because the missing and base views doesn't seem to be tested at all. Happy to be corrected if I've missed them, or write some!

[Tim Penhey (thumper)]

I've taken this and tweaked it slightly. Thanks.

review: Approve

=== modified file 'wikkid/view/base.py'
--- wikkid/view/base.py	2010-06-23 10:57:14 +0000
+++ wikkid/view/base.py	2010-11-21 01:44:57 +0000
@@ -110,7 +110,15 @@
         template = skin.get_template(self.template)
         content = template.render(**self.template_args())
         # Return the encoded content.
-        return Response(content.encode('utf-8'))
+        return self.make_response(content.encode('utf-8'))
+
+    def make_response(self, body):
+        """Construct the response object for this request.
+
+        :param body: The body of the response, as a unicode string.
+        :return: A `Response` object.
+        """
+        return Response(body)
 
     def render(self, skin):
         """Render the page.

=== modified file 'wikkid/view/missing.py'
--- wikkid/view/missing.py	2010-05-19 10:00:43 +0000
+++ wikkid/view/missing.py	2010-11-21 01:44:57 +0000
@@ -20,6 +20,11 @@
     is_default = True
     template = 'missing'
 
+    def make_response(self, body):
+        response = super(BaseView, self).make_response(body)
+        response.status = "404 Not Found"
+        return response
+
     @property
     def content(self):
         '%s Not found' % self.path