Merge ~mwhudson/ubuntu-cdimage:CDIMAGE_DVD-for-old-ubuntustudio into ubuntu-cdimage:main

Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 942a5a76183eb40f0e5c01cd69bf177d0f24880c
Merged at revision: 942a5a76183eb40f0e5c01cd69bf177d0f24880c
Proposed branch: ~mwhudson/ubuntu-cdimage:CDIMAGE_DVD-for-old-ubuntustudio
Merge into: ubuntu-cdimage:main
Diff against target: 27 lines (+5/-1)
2 files modified
bin/cron.daily-live (+4/-0)
lib/cdimage/germinate.py (+1/-1)
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+467624@code.launchpad.net

Commit message

Set CDIMAGE_DVD=1 for <= noble ubuntustudio images

Otherwise debian-cd does not name the ISO how the publication code
expects.

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This is looking correct, especially that the additional check for DVD was since long unnecessary. There would be bonus points for unit tests, but this is good anyway.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/cron.daily-live b/bin/cron.daily-live
2index a1c4e21..a6dfd82 100755
3--- a/bin/cron.daily-live
4+++ b/bin/cron.daily-live
5@@ -52,6 +52,10 @@ def main():
6 image_type = "daily-live"
7
8 config = Config(IMAGE_TYPE=image_type)
9+ if project == "ubuntustudio" and series <= "noble":
10+ # Without this, debian-cd does not name the ISO the way the
11+ # publication code expects.
12+ config["CDIMAGE_DVD"] = "1"
13 config["CDIMAGE_LIVE"] = "1"
14 if not build_image_set(config, options):
15 sys.exit(1)
16diff --git a/lib/cdimage/germinate.py b/lib/cdimage/germinate.py
17index 2cc50e2..a7dade0 100644
18--- a/lib/cdimage/germinate.py
19+++ b/lib/cdimage/germinate.py
20@@ -202,7 +202,7 @@ class GerminateOutput:
21 self._seeds.append(line.split(":", 1)[0])
22
23 def pool_seeds(self):
24- if not (self.config["CDIMAGE_DVD"] or self.config["CDIMAGE_LIVE"]):
25+ if not self.config["CDIMAGE_LIVE"]:
26 raise NoMasterSeeds("No seeds found for master task!")
27 project = self.config.project
28

Subscribers

People subscribed via source and target branches