Merge ~mwhudson/ubuntu-cdimage:ubuntu-core-installer-publication into ubuntu-cdimage:main

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: eb71710bf2f8d3c00698ac8747c59f96d7048613
Proposed branch: ~mwhudson/ubuntu-cdimage:ubuntu-core-installer-publication
Merge into: ubuntu-cdimage:main
Diff against target: 75 lines (+17/-1)
2 files modified
lib/cdimage/tests/test_tree.py (+8/-0)
lib/cdimage/tree.py (+9/-1)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+467310@code.launchpad.net

Commit message

update tree.py to handle publication of ubuntu-core-installer images.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

could we get some corresponding tests please?

review: Needs Fixing
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Added some tests, is that enough?

Revision history for this message
Steve Langasek (vorlon) wrote :

LGTM thanks

review: Approve
Revision history for this message
Steve Langasek (vorlon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/cdimage/tests/test_tree.py b/lib/cdimage/tests/test_tree.py
2index 63a5840..522229a 100644
3--- a/lib/cdimage/tests/test_tree.py
4+++ b/lib/cdimage/tests/test_tree.py
5@@ -241,6 +241,8 @@ class TestPublisher(TestCase):
6 ("daily-live", "ubuntu-core", "bionic", "live-core"),
7 ("daily-live", "ubuntu-core-desktop", "mantic",
8 "live-core-desktop"),
9+ ("daily-live", "ubuntu-core-installer", "noble",
10+ "ubuntu-core-installer"),
11 ("daily", "ubuntu-base", "bionic", "base"),
12 ("daily", "ubuntu-server", "bionic", "server"),
13 ("daily", "ubuntu-server", "focal", "legacy-server"),
14@@ -880,6 +882,12 @@ class TestDailyTreePublisher(TestCase):
15 "daily-live").publish_base)
16 self.assertEqual(
17 os.path.join(
18+ self.config.root, "www", "full", "ubuntu-core-installer",
19+ "daily-live"),
20+ self.make_publisher(
21+ "ubuntu-core-installer", "daily-live").publish_base)
22+ self.assertEqual(
23+ os.path.join(
24 self.config.root, "www", "full", "kubuntu", "daily-live"),
25 self.make_publisher("kubuntu", "daily-live").publish_base)
26 self.config["DIST"] = "hoary"
27diff --git a/lib/cdimage/tree.py b/lib/cdimage/tree.py
28index 6fac63b..12a45e3 100644
29--- a/lib/cdimage/tree.py
30+++ b/lib/cdimage/tree.py
31@@ -403,6 +403,8 @@ class Publisher:
32 return "netbook"
33 elif self.project == "ubuntu-server":
34 return "live-server"
35+ elif self.project == "ubuntu-core-installer":
36+ return "ubuntu-core-installer"
37 elif self.project in ("ubuntu-core", "ubuntu-appliance"):
38 return "live-core"
39 elif self.project == "ubuntu-core-desktop":
40@@ -440,7 +442,7 @@ class Publisher:
41 elif publish_type in (
42 "desktop", "live", "netbook",
43 "live-core", "live-core-desktop",
44- "live-server"):
45+ "live-server", "ubuntu-core-installer"):
46 return "daily-live"
47 elif publish_type == "minimal":
48 return "daily-minimal"
49@@ -499,6 +501,8 @@ class Publisher:
50 return "Ubuntu Core %s" % cd
51 elif publish_type == "live-core-desktop":
52 return "Ubuntu Core Desktop %s" % cd
53+ elif publish_type == "ubuntu-core-installer":
54+ return "Ubuntu Core Installer %s" % cd
55 elif publish_type == "desktop":
56 return "desktop %s" % cd
57 elif publish_type == "desktop-canary":
58@@ -758,6 +762,9 @@ class Publisher:
59 elif publish_type == "ubuntu-core-desktop":
60 sentences.append(
61 "Experimental Ubuntu Core Desktop installer images.")
62+ elif publish_type == "ubuntu-core-installer":
63+ sentences.append(
64+ "Experimental installer for Ubuntu Core.")
65 elif publish_type == "ubuntu-appliance":
66 sentences.append(
67 "An Ubuntu Appliance turns a computer into a specialised "
68@@ -1127,6 +1134,7 @@ class Publisher:
69 "preinstalled-core", "wubi",
70 "live-core",
71 "live-core-desktop",
72+ "ubuntu-core-installer",
73 "desktop-canary",
74 "desktop-legacy",
75 )

Subscribers

People subscribed via source and target branches