Merge ~mwhudson/ubuntu-cdimage:explicit-GENERATE_POOL into ubuntu-cdimage:main

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: f4eb2c6a16826c8ce1e3210771da9a1efa3ad600
Proposed branch: ~mwhudson/ubuntu-cdimage:explicit-GENERATE_POOL
Merge into: ubuntu-cdimage:main
Diff against target: 42 lines (+17/-14)
1 file modified
lib/cdimage/build.py (+17/-14)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+466006@code.launchpad.net

Commit message

do not run germinate if the image will not have a pool

And set GENERATE_POOL to 0 in this case

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Information
Revision history for this message
Michael Hudson-Doyle (mwhudson) :
Revision history for this message
Steve Langasek (vorlon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/cdimage/build.py b/lib/cdimage/build.py
2index 75d93e4..2c41598 100644
3--- a/lib/cdimage/build.py
4+++ b/lib/cdimage/build.py
5@@ -455,20 +455,23 @@ def build_image_set_locked(config, options):
6 apt_state_mgr = AptStateManager(config)
7 apt_state_mgr.setup()
8
9- log_marker("Germinating")
10- # Cannot use apt_state_mgr for germination until
11- # https://code.launchpad.net/~mwhudson/germinate/+git/
12- # germinate-1/+merge/456723
13- # is merged.
14- germination = Germination(config)
15- germination.run()
16-
17- log_marker("Generating new task lists")
18- germinate_output = germination.output()
19- germinate_output.write_tasks()
20-
21- log_marker("Checking for other task changes")
22- germinate_output.update_tasks(date)
23+ if config.project == "ubuntu-core-desktop":
24+ config["GENERATE_POOL"] = "0"
25+ else:
26+ log_marker("Germinating")
27+ # Cannot use apt_state_mgr for germination until
28+ # https://code.launchpad.net/~mwhudson/germinate/+git/
29+ # germinate-1/+merge/456723
30+ # is merged.
31+ germination = Germination(config)
32+ germination.run()
33+
34+ log_marker("Generating new task lists")
35+ germinate_output = germination.output()
36+ germinate_output.write_tasks()
37+
38+ log_marker("Checking for other task changes")
39+ germinate_output.update_tasks(date)
40
41 if config["CDIMAGE_LIVE"]:
42 log_marker("Downloading live filesystem images")

Subscribers

People subscribed via source and target branches