Merge lp:~mwhudson/loggerhead/no-more-mootools into lp:loggerhead

[Michael Hudson-Doyle]

[Michael Hudson-Doyle (mwhudson)]

Hi there,

This branch removes mootools and all uses of it from loggerhead, replacing it with YUI3 lurve.

I didn't fully replicate Fx.Slide, instead going for a simple animation of height. I stole the idea of how to compute the height of a display: none element without flickering from whoever did it like this at the epic.

The diff is quite chunky as it basically rewrites all the JS in the project, no way around that really.

Cheers,
mwh

[Paul Hummer (rockstar)]

Michael-

  This is good work. I noticed a really odd issue when the content of
td.sumcell pushes the content of td.autcell into two lines and so makes all
the table rows two lines high. It's a little funky, not sure if that's
really an issue here though. Could you please file a bug on it? If you need
to reproduce, unfold rev 265 of loggerhead using serve-branches.

  Other than that, I'm good with this branch landing. We talked about the
declarations of functions and the curly brace. It doesn't look like we have a
standard for it right now though, so don't sweat it.

Cheers,
Paul

[Paul Hummer (rockstar)]

review: Approve

[Tim Penhey (thumper)]

On Tue, 24 Feb 2009 14:19:17 Paul Hummer wrote:
> Michael-
>
> This is good work. I noticed a really odd issue when the content of
> td.sumcell pushes the content of td.autcell into two lines and so makes all
> the table rows two lines high. It's a little funky, not sure if that's
> really an issue here though. Could you please file a bug on it? If you
> need to reproduce, unfold rev 265 of loggerhead using serve-branches.
>
> Other than that, I'm good with this branch landing. We talked about the
> declarations of functions and the curly brace. It doesn't look like we
> have a standard for it right now though, so don't sweat it.
>
> Cheers,
> Paul

Testing email for me.

[Michael Hudson-Doyle (mwhudson)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

hi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmjTxUACgkQeTTOPm7A7kjY4gCeKfcLCfteS0ReNsqJnRCxto9O
ciwAnRrh7k16zEFelczSdfRtO7128CbM
=Nv46
-----END PGP SIGNATURE-----