Merge lp:~mwhudson/loggerhead/fix-empty-files-page into lp:loggerhead

Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Martin Albisetti
Approved revision: 271
Merged at revision: not available
Proposed branch: lp:~mwhudson/loggerhead/fix-empty-files-page
Merge into: lp:loggerhead
To merge this branch: bzr merge lp:~mwhudson/loggerhead/fix-empty-files-page
Reviewer Review Type Date Requested Status
Martin Albisetti Approve
Review via email: mp+3511@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This branch fixes the files view in an empty branch.

I think there must have been a mismerge at some point -- there was weird, half-duplicated code in inventory_ui.py. The code isn't maximally clear yet, but it works at least :)

I added a test and converted the existing tests to use bzrlib TestCase's (prompted by bzr-avahi going nuts while running the tests with py.test :).

Revision history for this message
Martin Albisetti (beuno) wrote :

OMG, this has TESTS! :)

Just one small comment, there's some whitespace laying around in:

+....
+ def test_inventory(self):
+ app = self.setUpLoggerhead()
+ res = app.get('/files')
+ res.mustcontain('No revisions!')

review: Approve
272. By Michael Hudson-Doyle

clean up whitespace

Subscribers

People subscribed via source and target branches