Merge lp:~mwhudson/loggerhead/customizable-branch-location into lp:loggerhead

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: not available
Proposed branch: lp:~mwhudson/loggerhead/customizable-branch-location
Merge into: lp:loggerhead
To merge this branch: bzr merge lp:~mwhudson/loggerhead/customizable-branch-location
Reviewer Review Type Date Requested Status
Martin Albisetti Approve
Review via email: mp+3716@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Sorry no time to write this, see if you can figure it out :)

Revision history for this message
Martin Albisetti (beuno) wrote :

I... don't quite understand.
Also, this looks maybe wrong?

  === modified file 'loggerhead/apps/filesystem.py'
  --- loggerhead/apps/filesystem.py^I2009-01-23 19:00:35 +0000
  +++ loggerhead/apps/filesystem.py^I2009-02-18 10:36:48 +0000
  @@ -32,7 +32,7 @@
               is_root = False
           branch_app = BranchWSGIApp(
               branch, name, {'cachepath': sql_dir}, self.root.graph_cache,
  - is_root=is_root)
  + is_root=is_root, served_url='lp:loggerhead')
           return branch_app.app

273. By Michael Hudson-Doyle

oops :)

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

>I... don't quite understand.

Sorry. The idea is to be able to customize the location shown in the "To get this branch, use:
bzr branch http://localhost:8080" text -- for example on launchpad we should use a lp:foo url.

> Also, this looks maybe wrong?

Quite right!

Revision history for this message
Martin Albisetti (beuno) wrote :

Ah!
Now it makes sense.
Pending that fix of removing "lp...", it's good to go.
A very good idea :)

review: Approve

Subscribers

People subscribed via source and target branches