Merge lp:~mwhudson/livecd-rootfs/subiquity-serial into lp:livecd-rootfs

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: 1608
Proposed branch: lp:~mwhudson/livecd-rootfs/subiquity-serial
Merge into: lp:livecd-rootfs
Diff against target: 78 lines (+32/-12)
5 files modified
debian/changelog (+7/-0)
live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/serial-getty@.service.d/subiquity-serial.conf (+2/-0)
live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/serial-subiquity@.service (+23/-0)
live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/subiquity-debug@.service (+0/-6)
live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/subiquity.service (+0/-6)
To merge this branch: bzr merge lp:~mwhudson/livecd-rootfs/subiquity-serial
Reviewer Review Type Date Requested Status
Adam Conrad (community) Approve
Review via email: mp+336178@code.launchpad.net

Description of the change

Adam managed to convince me that we shouldn't assume any serial consoles on x86 by default but if the user does tell us/systemd about one, we should probably run subiquity on it rather than a getty the user cannot log in at.

To post a comment you must log in.
1604. By Michael Hudson-Doyle

remove some commented out gunk from .service files

1605. By Michael Hudson-Doyle

merge trunk

Revision history for this message
Adam Conrad (adconrad) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2018-01-30 11:51:23 +0000
3+++ debian/changelog 2018-01-31 08:59:58 +0000
4@@ -1,3 +1,10 @@
5+livecd-rootfs (2.493) UNRELEASED; urgency=medium
6+
7+ * Run subiquity on any serial consoles that the user told systemd
8+ about.
9+
10+ -- Michael Hudson-Doyle <michael.hudson@ubuntu.com> Wed, 31 Jan 2018 21:58:33 +1300
11+
12 livecd-rootfs (2.492) bionic; urgency=medium
13
14 * Oops. I shouldn't reference my private stuff.
15
16=== added directory 'live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/serial-getty@.service.d'
17=== added file 'live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/serial-getty@.service.d/subiquity-serial.conf'
18--- live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/serial-getty@.service.d/subiquity-serial.conf 1970-01-01 00:00:00 +0000
19+++ live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/serial-getty@.service.d/subiquity-serial.conf 2018-01-31 08:59:58 +0000
20@@ -0,0 +1,2 @@
21+[Service]
22+ExecStartPre=/bin/systemctl start serial-subiquity@%i.service
23
24=== added file 'live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/serial-subiquity@.service'
25--- live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/serial-subiquity@.service 1970-01-01 00:00:00 +0000
26+++ live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/serial-subiquity@.service 2018-01-31 08:59:58 +0000
27@@ -0,0 +1,23 @@
28+[Unit]
29+Description=Subiquity, the installer for Ubuntu Server %I
30+BindsTo=dev-%i.device
31+After=dev-%i.device systemd-user-sessions.service plymouth-quit-wait.service
32+After=rc-local.service
33+ConditionPathExists=!/run/subiquity/complete
34+StartLimitInterval=0
35+
36+[Service]
37+Environment=PYTHONPATH=/usr/share/subiquity
38+ExecStartPre=/bin/systemctl stop serial-getty@%I
39+ExecStart=/sbin/agetty -n --keep-baud -l /snap/bin/subiquity --login-options "--serial" 115200,38400,9600 %I $TERM
40+ExecStopPost=/bin/systemctl start serial-getty@%I
41+Type=idle
42+Restart=always
43+RestartSec=0
44+UtmpIdentifier=%I
45+TTYPath=/dev/%I
46+TTYReset=yes
47+TTYVHangup=yes
48+KillMode=process
49+IgnoreSIGPIPE=no
50+SendSIGHUP=yes
51
52=== modified file 'live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/subiquity-debug@.service'
53--- live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/subiquity-debug@.service 2017-03-21 22:32:55 +0000
54+++ live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/subiquity-debug@.service 2018-01-31 08:59:58 +0000
55@@ -22,9 +22,3 @@
56 KillMode=process
57 IgnoreSIGPIPE=no
58 SendSIGHUP=yes
59-
60-#KillMode=process
61-#Restart=always
62-#StandardInput=tty-force
63-#StandardOutput=tty
64-#StandardError=tty
65
66=== modified file 'live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/subiquity.service'
67--- live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/subiquity.service 2017-10-18 00:26:08 +0000
68+++ live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/subiquity.service 2018-01-31 08:59:58 +0000
69@@ -26,9 +26,3 @@
70 KillMode=process
71 IgnoreSIGPIPE=no
72 SendSIGHUP=yes
73-
74-#KillMode=process
75-#Restart=always
76-#StandardInput=tty-force
77-#StandardOutput=tty
78-#StandardError=tty

Subscribers

People subscribed via source and target branches